Skip to content

Commit

Permalink
nixos/desktop-managers: Fix eval
Browse files Browse the repository at this point in the history
nixos/lib/utils.nix is actually passed as `utils` argument to modules
so #168194 broke the eval.

Fixes: #168569
  • Loading branch information
jtojnar committed Apr 14, 2022
1 parent 056b2b3 commit 5db9253
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 10 deletions.
4 changes: 2 additions & 2 deletions nixos/modules/services/x11/desktop-managers/cinnamon.nix
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{ config, lib, pkgs, ... }:
{ config, lib, pkgs, utils, ... }:

with lib;

Expand Down Expand Up @@ -196,7 +196,7 @@ in
programs.evince.enable = mkDefault true;
programs.file-roller.enable = mkDefault true;

environment.systemPackages = with pkgs // pkgs.gnome // pkgs.cinnamon; lib.utils.removePackagesByName [
environment.systemPackages = with pkgs // pkgs.gnome // pkgs.cinnamon; utils.removePackagesByName [
# cinnamon team apps
bulky
blueberry
Expand Down
8 changes: 4 additions & 4 deletions nixos/modules/services/x11/desktop-managers/gnome.nix
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{ config, lib, pkgs, ... }:
{ config, lib, pkgs, utils, ... }:

with lib;

Expand Down Expand Up @@ -456,7 +456,7 @@ in
(mkIf serviceCfg.core-utilities.enable {
environment.systemPackages =
with pkgs.gnome;
lib.utils.removePackagesByName
utils.removePackagesByName
([
baobab
cheese
Expand Down Expand Up @@ -516,7 +516,7 @@ in
})

(mkIf serviceCfg.games.enable {
environment.systemPackages = with pkgs.gnome; lib.utils.removePackagesByName [
environment.systemPackages = with pkgs.gnome; utils.removePackagesByName [
aisleriot
atomix
five-or-more
Expand All @@ -542,7 +542,7 @@ in

# Adapt from https://gitlab.gnome.org/GNOME/gnome-build-meta/-/blob/3.38.0/elements/core/meta-gnome-core-developer-tools.bst
(mkIf serviceCfg.core-developer-tools.enable {
environment.systemPackages = with pkgs.gnome; lib.utils.removePackagesByName [
environment.systemPackages = with pkgs.gnome; utils.removePackagesByName [
dconf-editor
devhelp
pkgs.gnome-builder
Expand Down
4 changes: 2 additions & 2 deletions nixos/modules/services/x11/desktop-managers/lxqt.nix
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{ config, lib, pkgs, ... }:
{ config, lib, pkgs, utils, ... }:

with lib;

Expand Down Expand Up @@ -51,7 +51,7 @@ in
environment.systemPackages =
pkgs.lxqt.preRequisitePackages ++
pkgs.lxqt.corePackages ++
(lib.utils.removePackagesByName
(utils.removePackagesByName
pkgs.lxqt.optionalPackages
config.environment.lxqt.excludePackages);

Expand Down
4 changes: 2 additions & 2 deletions nixos/modules/services/x11/desktop-managers/mate.nix
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{ config, lib, pkgs, ... }:
{ config, lib, pkgs, utils, ... }:

with lib;

Expand Down Expand Up @@ -47,7 +47,7 @@ in
# Debugging
environment.sessionVariables.MATE_SESSION_DEBUG = mkIf cfg.debug "1";

environment.systemPackages = lib.utils.removePackagesByName
environment.systemPackages = utils.removePackagesByName
(pkgs.mate.basePackages ++
pkgs.mate.extraPackages ++
[
Expand Down

1 comment on commit 5db9253

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jtojnar, you pushed a commit directly to master/release branch
instead of going through a Pull Request.

That's highly discouraged beyond the few exceptions listed
on #118661

Please sign in to comment.