Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xserver exclude packages #168194

Merged
merged 2 commits into from
Apr 13, 2022

Conversation

SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Apr 10, 2022

Description of changes

#167233 (comment)

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

to remove packages environment.systemPackages
@github-actions github-actions bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: pantheon The Pantheon desktop environment labels Apr 11, 2022
@SuperSandro2000
Copy link
Member Author

Or should it be moved to https://github.com/NixOS/nixpkgs/blob/master/lib/attrsets.nix ? IDK

nixos/lib/utils.nix Outdated Show resolved Hide resolved
@amaxine
Copy link
Contributor

amaxine commented Apr 13, 2022

I cannot rebuild my system since this was merged, previous commit builds fine tho.

error: attribute 'utils' missing

       at /home/systems/nixpkgs/nixos/modules/services/x11/desktop-managers/gnome.nix:459:9:

          458|         with pkgs.gnome;
          459|         lib.utils.removePackagesByName
             |         ^
          460|           ([
(use '--show-trace' to show detailed location information)

jtojnar added a commit that referenced this pull request Apr 14, 2022
nixos/lib/utils.nix is actually passed as `utils` argument to modules
so #168194 broke the eval.

Fixes: #168569
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos 6.topic: pantheon The Pantheon desktop environment 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants