Skip to content

Commit

Permalink
gnupg: Add gnupg 2.1 as default
Browse files Browse the repository at this point in the history
Additionally, move all gnupg expressions into the gnupg folder.
  • Loading branch information
wkennington committed Nov 6, 2014
1 parent 3d04993 commit 850da18
Show file tree
Hide file tree
Showing 5 changed files with 41 additions and 3 deletions.
File renamed without changes.
File renamed without changes.
File renamed without changes.
30 changes: 30 additions & 0 deletions pkgs/tools/security/gnupg/21.nix
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
{ fetchurl, stdenv, pkgconfig, libgcrypt, libassuan, libksba, npth
, readline ? null, libusb ? null, gnutls ? null, adns ? null, openldap ? null
, zlib ? null, bzip2 ? null, pinentry ? null
}:

with stdenv.lib;
stdenv.mkDerivation rec {
name = "gnupg-2.1.0";

src = fetchurl {
url = "mirror://gnupg/gnupg/${name}.tar.bz2";
sha256 = "12q5shx6ldqad3rky154nv8f2cy57sxy9idivz93ggqm1bsw7a0n";
};

buildInputs = [
pkgconfig libgcrypt libassuan libksba npth
readline libusb gnutls adns openldap zlib bzip2
];

configureFlags =
optional (pinentry != null) "--with-pinentry-pgm=${pinentry}/bin/pinentry";

meta = with stdenv.lib; {
homepage = http://gnupg.org;
description = "a complete and free implementation of the OpenPGP standard";
license = licenses.gpl3Plus;
maintainers = with maintainers; [ wkennington ];
platforms = platforms.all;
};
}
14 changes: 11 additions & 3 deletions pkgs/top-level/all-packages.nix
Original file line number Diff line number Diff line change
Expand Up @@ -1267,14 +1267,22 @@ let

gnupatch = callPackage ../tools/text/gnupatch { };

gnupg1orig = callPackage ../tools/security/gnupg1 { };
gnupg1orig = callPackage ../tools/security/gnupg/1.nix { };

gnupg1compat = callPackage ../tools/security/gnupg1compat { };
gnupg1compat = callPackage ../tools/security/gnupg/1compat.nix { };

# use config.packageOverrides if you prefer original gnupg1
gnupg1 = gnupg1compat;

gnupg = callPackage ../tools/security/gnupg { libusb = libusb1; };
gnupg20 = callPackage ../tools/security/gnupg/20.nix {
libgcrypt = libgcrypt_1_6;
};

gnupg21 = callPackage ../tools/security/gnupg/21.nix {
libgcrypt = libgcrypt_1_6;
};

gnupg = gnupg21;

gnuplot = callPackage ../tools/graphics/gnuplot { };

Expand Down

9 comments on commit 850da18

@peti
Copy link
Member

@peti peti commented on 850da18 Nov 7, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wkennington, I believe this commit broke git-annex: http://hydra.cryp.to/build/237313/nixlog/1/raw. Are you sure that gnupg1compat works correctly with gnupg version 2.1?

@wkennington
Copy link
Contributor Author

@wkennington wkennington commented on 850da18 Nov 7, 2014 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peti
Copy link
Member

@peti peti commented on 850da18 Nov 7, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit 4c84621 fixed that test suite failure, so clearly there is a difference between 2.1 and 2.0 as far as the compat layer is concerned.

@wkennington
Copy link
Contributor Author

@wkennington wkennington commented on 850da18 Nov 7, 2014 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peti
Copy link
Member

@peti peti commented on 850da18 Nov 7, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would the compatibility layer to version 1.0 change at all? Wouldn't that negate the entire purpose of of a "compatibility layer" that emulates an old interface?

@wkennington
Copy link
Contributor Author

@wkennington wkennington commented on 850da18 Nov 7, 2014 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peti
Copy link
Member

@peti peti commented on 850da18 Nov 7, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but gnupg 2.x implements a the old command-line interface from version 1.x. That is not supposed to change, no?

@wkennington
Copy link
Contributor Author

@wkennington wkennington commented on 850da18 Nov 7, 2014 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peti
Copy link
Member

@peti peti commented on 850da18 Nov 7, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I don't care that much about the subject, to be honest. Switching gnupg1compat back to gnupg version 2.0 fixes the issue, so that is good enough for me.

Please sign in to comment.