Skip to content

Commit

Permalink
ghcHEAD: Add back response files patch
Browse files Browse the repository at this point in the history
  • Loading branch information
shlevy committed Nov 17, 2016
1 parent d0d3330 commit da547f7
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
--- ghc/compiler/main/SysTools.hs 2016-11-09 14:03:05.304528147 -0500
+++ ghc2/compiler/main/SysTools.hs 2016-11-09 14:00:19.712934686 -0500
@@ -421,7 +421,7 @@
args1 = map Option (getOpts dflags opt_c)
args2 = args0 ++ args1 ++ args
mb_env <- getGccEnv args2
- runSomethingResponseFile dflags cc_filter "C Compiler" p args2 mb_env
+ runSomethingFiltered dflags cc_filter "C Compiler" p args2 mb_env
where
-- discard some harmless warnings from gcc that we can't turn off
cc_filter = unlines . doFilter . lines
@@ -911,7 +911,7 @@
args1 = map Option (getOpts dflags opt_l)
args2 = args0 ++ linkargs ++ args1 ++ args
mb_env <- getGccEnv args2
- runSomethingResponseFile dflags ld_filter "Linker" p args2 mb_env
+ runSomethingFiltered dflags ld_filter "Linker" p args2 mb_env
where
ld_filter = case (platformOS (targetPlatform dflags)) of
OSSolaris2 -> sunos_ld_filter
4 changes: 4 additions & 0 deletions pkgs/development/compilers/ghc/head.nix
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,10 @@ in stdenv.mkDerivation (rec {
sha256 = "1ryggmz961qd0fl50rkjjvi6g9azwla2vx9310a9nzjaj5x6ib4y";
};

# This shouldn't be necessary since 1ad1edbb32ce01ba8b47d8e8dad357b0edd6a4dc, but
# see http://hydra.cryp.to/build/2061608/nixlog/1/raw
patches = [ ./ghc-HEAD-dont-pass-linker-flags-via-response-files.patch ];

postPatch = ''
echo ${version} >VERSION
echo ${rev} >GIT_COMMIT_ID
Expand Down

2 comments on commit da547f7

@shlevy
Copy link
Member Author

@shlevy shlevy commented on da547f7 Nov 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peti this fixes the issue

@corngood Any chance you could take a look at the log and see why your response files patch wasn't enough here?

@corngood
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, sorry for not getting to this sooner. I didn't see anything obvious in the in that log, so I'll have to try building it myself.

Please sign in to comment.