Skip to content

Commit

Permalink
haskell: drop package sets for GHC 6.12.x, 7.0.x, 7.2.x, 7.4.x, and 7…
Browse files Browse the repository at this point in the history 
….6.x

These old package sets have been broken and unmaintained for a long time now.
  • Loading branch information
@peti
peti committed Dec 26, 2017
1 parent e98e7fb commit eb0da3e
Show file tree
Hide file tree
Showing 6 changed files with 0 additions and 535 deletions.
94 changes: 0 additions & 94 deletions pkgs/development/haskell-modules/configuration-ghc-6.12.x.nix
View file

This file was deleted.

85 changes: 0 additions & 85 deletions pkgs/development/haskell-modules/configuration-ghc-7.0.x.nix
View file

This file was deleted.

89 changes: 0 additions & 89 deletions pkgs/development/haskell-modules/configuration-ghc-7.2.x.nix
View file

This file was deleted.

117 changes: 0 additions & 117 deletions pkgs/development/haskell-modules/configuration-ghc-7.4.x.nix
View file

This file was deleted.

10 comments on commit eb0da3e

@grahamc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @peti this broke master's evaluation, causing other PRs to fail checks: https://gist.github.com/GrahamcOfBorg/39b7e79e5ad5e6e024d04e244c375790 note your original PR also failed these checks, a red ❌ means an actual problem now :)

should

     jhc = callPackage ../development/compilers/jhc {
       inherit (packages.ghc763) ghcWithPackages;
     };

be deleted?

@lukateras
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it shouldn't, we still have JHC in tree. It seems that now JHC is broken, unless it works with newer GHC versions.

@peti
Copy link
Member Author

@peti peti commented on eb0da3e Dec 26, 2017 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grahamc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you so much for being so fast :D

@lukateras
Copy link
Member

@lukateras lukateras commented on eb0da3e Dec 26, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peti: pkgs/top-level/haskell-packages.nix stills refers to GHC 6.x, 7.0.x, 7.2.x (but not to package sets). Is that intended?

@grahamc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, we're seeing infinite recursion in the haskell code:

error: while evaluating anonymous function at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/grahamc-zoidberg/.gc-of-borg-outpaths.nix:35:12, called from /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/grahamc-zoidberg/lib/attrsets.nix:199:52:
while evaluating the attribute ‘i686-linux’ at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/grahamc-zoidberg/lib/attrsets.nix:185:41:
while evaluating anonymous function at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/grahamc-zoidberg/pkgs/top-level/release-lib.nix:66:6, called from /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/grahamc-zoidberg/lib/attrsets.nix:282:43:
while evaluating ‘hydraJob’ at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/grahamc-zoidberg/lib/customisation.nix:157:14, called from /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/grahamc-zoidberg/pkgs/top-level/release-lib.nix:66:14:
while evaluating the attribute ‘drvPath’ at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/grahamc-zoidberg/lib/customisation.nix:174:13:
while evaluating the attribute ‘drvPath’ at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/grahamc-zoidberg/lib/customisation.nix:145:40:
while evaluating the attribute ‘buildInputs’ of the derivation ‘SCalendar-1.1.0’ at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/grahamc-zoidberg/pkgs/stdenv/generic/make-derivation.nix:98:11:
while evaluating the attribute ‘buildInputs’ of the derivation ‘scalendar-1.2.0’ at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/grahamc-zoidberg/pkgs/stdenv/generic/make-derivation.nix:98:11:
infinite recursion encountered, at undefined position

@peti
Copy link
Member Author

@peti peti commented on eb0da3e Dec 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pkgs/top-level/haskell-packages.nix stills refers to GHC 6.x, 7.0.x, 7.2.x (but not to package sets). Is that intended?

Yes, that's intended. We'll keep the compilers around for now.

@grahamc, that evaluation error is unrelated to this commit. The scalendar package is broken, because upstream publishes incorrect dependencies.

@grahamc
Copy link
Member

@grahamc grahamc commented on eb0da3e Dec 26, 2017 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grahamc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peti can you hop on IRC sometime to help me sort this out?

@peti
Copy link
Member Author

@peti peti commented on eb0da3e Dec 26, 2017 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.