Skip to content

Commit

Permalink
Merge pull request #25183 from ahmedtd/fix-wrap-gapps-hook
Browse files Browse the repository at this point in the history
wrapGAppsHook: Correct `wrapProgram` invocations
  • Loading branch information
peti committed Apr 28, 2017
2 parents 7f3b857 + 8b9f153 commit edcff00
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions pkgs/build-support/setup-hooks/wrap-gapps-hook.sh
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,10 @@ wrapGAppsHook() {
done

if [ -z "$dontWrapGApps" ]; then
for i in $prefix/bin/* $prefix/libexec/*; do
echo "Wrapping app $i"
wrapProgram "$i" "${gappsWrapperArgs[@]}"
find "${prefix}/bin" "${prefix}/libexec" -type f -executable -print0 \
| while IFS= read -r -d '' file; do
echo "Wrapping program $file"
wrapProgram "$file" "${gappsWrapperArgs[@]}"
done
fi
}
Expand Down

2 comments on commit edcff00

@pbogdan
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be breaking packages where $prefix/libexec is not present - https://hydra.nixos.org/build/52065519/nixlog/1

/cc @ahmedtd author of the commit

@ahmedtd
Copy link
Contributor

@ahmedtd ahmedtd commented on edcff00 Apr 28, 2017 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.