-
-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spidermonkey_78 fails to build on staging #104483
Comments
For what it is worth I ran a bisect on this:
Reverting 11806b6 seems to fix it. |
Thank you. I was afraid it had something to do with a Python change. |
Oh, the patch is indented with 2 spaces... |
Fixing the indent on the python 3.7+ patch (see diff below) didn't change the situation. Did you mean something else in the patches? diff --git a/pkgs/development/interpreters/python/cpython/3.7/fix-finding-headers-when-cross-compiling.patch b/pkgs/development/interpreters/python/cpython/3.7/fix-finding-headers-when-cross-compiling.patch
index 543e267e94b..12020586582 100644
--- a/pkgs/development/interpreters/python/cpython/3.7/fix-finding-headers-when-cross-compiling.patch
+++ b/pkgs/development/interpreters/python/cpython/3.7/fix-finding-headers-when-cross-compiling.patch
@@ -36,16 +36,16 @@ index 37feae5df7..6d4ad06696 100644
- python_dir = 'python' + get_python_version() + build_flags
- return os.path.join(prefix, "include", python_dir)
+ if prefix is None:
-+ if plat_specific:
-+ return get_config_var('CONFINCLUDEPY')
-+ else:
-+ return get_config_var('INCLUDEPY')
++ if plat_specific:
++ return get_config_var('CONFINCLUDEPY')
++ else:
++ return get_config_var('INCLUDEPY')
+ else:
-+ python_dir = 'python' + get_python_version() + build_flags
-+ return os.path.join(prefix, "include", python_dir)
++ python_dir = 'python' + get_python_version() + build_flags
++ return os.path.join(prefix, "include", python_dir)
elif os.name == "nt":
+ if prefix is None:
-+ prefix = plat_specific and BASE_EXEC_PREFIX or BASE_PREFIX
++ prefix = plat_specific and BASE_EXEC_PREFIX or BASE_PREFIX
if python_build:
# Include both the include and PC dir to ensure we can find
# pyconfig.h |
My build also finished, and indeed, changing indentation did not fix it. |
Moving We should not move |
reverted the revert and modified it in 6100bc2 |
On 07:29 23.11.20, Frederik Rietdijk wrote:
reverted the revert in 6100bc2
spidermonkey_78 builds, cross-compiling numpy and cffi still works, and `python3.tests` also succeeds.
If cross-compilation still works what was the point of the actual patch?
Wasn't that also just added for cross compilation support?
|
Yes, what I meant is that my revert now fixes the original commit so spidermonkey builds, while not breaking cross-compilation. |
Describe the bug
spidermonkey_78 fails to build on staging.
To Reproduce
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.
Notify maintainers
@abbradar @lostnet
Metadata
Please run
nix-shell -p nix-info --run "nix-info -m"
and paste the result.Nixpkgs staging at 54cb417.
Maintainer information:
The text was updated successfully, but these errors were encountered: