Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

antBuild doesn't call the standard pre/post hooks #10931

Closed
copumpkin opened this issue Nov 10, 2015 · 7 comments
Closed

antBuild doesn't call the standard pre/post hooks #10931

copumpkin opened this issue Nov 10, 2015 · 7 comments
Labels
0.kind: enhancement 1.severity: mass-rebuild

Comments

@copumpkin
Copy link
Member

I stared at it for a while wondering my preBuild wasn't getting called before realizing that it was overriding buildPhase without calling runHook preBuild and friends. Doesn't seem ideal!
@nbp
Copy link
Member

nbp commented Nov 20, 2015

I think this would be a nice addition to setup.sh, but I do not see any other way to warn about it without having a mass-rebuild.

@copumpkin
Copy link
Member Author

It seems like it would only need to touch antBuild, right? Or what am I missing?

@nbp
Copy link
Member

nbp commented Nov 20, 2015

I thought that setup.sh would have been a good place to add assertions for that in general.

@Profpatsch
Copy link
Member

(triage) is that still the case?

@rasendubi rasendubi mentioned this issue Jul 24, 2016
Merged
7 tasks
@rasendubi
Copy link
Member

Checked the source and that's still an issue. Opened a PR to fix that: #17241

@Profpatsch
Copy link
Member

Very good. Will the “Fixes #bla” automatically close this issue once it is merged?

@rasendubi
Copy link
Member

Yes, it should.

rasendubi added a commit to rasendubi/nixpkgs that referenced this issue Jul 25, 2016
@rasendubi
antBuild: run default hooks
bb3fc68 
Fixes NixOS#10931.
antBuild overrides buildPhase and installPhase without calling default
hooks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0.kind: enhancement 1.severity: mass-rebuild
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@copumpkin @nbp @rasendubi @Profpatsch