-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QEmu: virtiofsd prone to be garbage collected. #113172
Comments
It's not perfect, but adding the following snippet to environment.systemPackages = [
(pkgs.stdenv.mkDerivation {
name = "virtiofsd-link";
buildCommand = ''
mkdir -p $out/bin
ln -s ${pkgs.qemu}/libexec/virtiofsd $out/bin/
'';
})
]; I have the following line in my virtual machine XML to make use of it:
|
I marked this as stale due to inactivity. → More info |
Still important to me. |
Fixes NixOS#113172. This is needed to get libvirt to find the virtiofsd binary through PATH, working around systemPackages only adding things in /bin to PATH.
Sorry about the spam, I had to push to my fork in order to test it and I managed to have this crappy typo that I missed for a while.. Anyway, that PR should fix it. |
According to the QEMU documentation, virtiofsd is supposed to be run directly by users. It therefore makes sense to have it in bin/, so it will be in PATH. Such a change wouldn't make sense upstream, because it would then conflict with the virtiofsd package, which is generally preferred if available. But in Nixpkgs, we don't have to worry about that and can just make QEMU's virtiofsd a lower priority than the one from the dedicated package. [1]: https://qemu.readthedocs.io/en/latest/tools/virtiofsd.html Fixes: NixOS#113172 ("QEmu: virtiofsd prone to be garbage collected.") Fixes: NixOS#153007 ("nixos/libvirtd: add ${cfg.qemu.package}/libexec to PATH")
According to the QEMU documentation, virtiofsd is supposed to be run directly by users. It therefore makes sense to have it in bin/, so it will be in PATH. Such a change wouldn't make sense upstream, because it would then conflict with the virtiofsd package, which is generally preferred if available. But in Nixpkgs, we don't have to worry about that and can just make QEMU's virtiofsd a lower priority than the one from the dedicated package. [1]: https://qemu.readthedocs.io/en/latest/tools/virtiofsd.html Fixes: #113172 ("QEmu: virtiofsd prone to be garbage collected.") Fixes: #153007 ("nixos/libvirtd: add ${cfg.qemu.package}/libexec to PATH")
That's what Maintaining |
Fixes NixOS#113172. This is needed to get libvirt to find the virtiofsd binary through PATH, working around systemPackages only adding things in /bin to PATH.
Fixes NixOS#113172. This is needed to get libvirt to find the virtiofsd binary through PATH, working around systemPackages only adding things in /bin to PATH.
Fixes NixOS#113172. This is needed to get libvirt to find the virtiofsd binary through PATH, working around systemPackages only adding things in /bin to PATH.
Fixes NixOS#113172. This is needed to get libvirt to find the virtiofsd binary through PATH, working around systemPackages only adding things in /bin to PATH.
Fixes NixOS#113172. This is needed to get libvirt to find the virtiofsd binary through PATH, working around systemPackages only adding things in /bin to PATH.
Fixes NixOS#113172. This is needed to get libvirt to find the virtiofsd binary through PATH, working around systemPackages only adding things in /bin to PATH.
Describe the bug
libvirt can't find
virtfiofsd
I'm unsure how to reference virtiofsd via libvirt xml without it being garbage collected.
I'm currently hard coding nix store:
Expected behavior
A consistent reference to virtiofsd either via a link in
/run/current-system
or putting it on the $PATH.Additional context
https://libvirt.org/kbase/virtiofs.html#host-setup
Notify maintainers
@eelco
The text was updated successfully, but these errors were encountered: