nixos/libvirtd: add ${cfg.qemu.package}/libexec to PATH #153007
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes NixOS#113172. This is needed to get libvirt to find the virtiofsd binary through PATH, working around systemPackages only adding things in /bin to PATH.
alyssais
added a commit
to alyssais/nixpkgs
that referenced
this pull request
Mar 3, 2022
According to the QEMU documentation, virtiofsd is supposed to be run directly by users. It therefore makes sense to have it in bin/, so it will be in PATH. Such a change wouldn't make sense upstream, because it would then conflict with the virtiofsd package, which is generally preferred if available. But in Nixpkgs, we don't have to worry about that and can just make QEMU's virtiofsd a lower priority than the one from the dedicated package. [1]: https://qemu.readthedocs.io/en/latest/tools/virtiofsd.html Fixes: NixOS#113172 ("QEmu: virtiofsd prone to be garbage collected.") Fixes: NixOS#153007 ("nixos/libvirtd: add ${cfg.qemu.package}/libexec to PATH")
13 tasks
|
Hi, sorry it's taken me so long to get to this. I've opened #162635, which I think is a better solution as it's not libvirt-specific, and I would appreciate your review. |
alyssais
added a commit
that referenced
this pull request
Mar 4, 2022
According to the QEMU documentation, virtiofsd is supposed to be run directly by users. It therefore makes sense to have it in bin/, so it will be in PATH. Such a change wouldn't make sense upstream, because it would then conflict with the virtiofsd package, which is generally preferred if available. But in Nixpkgs, we don't have to worry about that and can just make QEMU's virtiofsd a lower priority than the one from the dedicated package. [1]: https://qemu.readthedocs.io/en/latest/tools/virtiofsd.html Fixes: #113172 ("QEmu: virtiofsd prone to be garbage collected.") Fixes: #153007 ("nixos/libvirtd: add ${cfg.qemu.package}/libexec to PATH")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #113172. This is needed to get libvirt to find the virtiofsd
binary through PATH, working around systemPackages only adding things in
/bin to PATH.
Example usage in libvirtd domain configuration
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usageall binary filesI just checked virtiofsd was added toPATH. It was.nixos/doc/manual/md-to-db.shto update generated release notes