-
-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sage dependency updates #114881
sage dependency updates #114881
Conversation
0d39527
to
09b2318
Compare
09b2318
to
71db031
Compare
@ofborg build sage |
@collares ping :) |
71db031
to
09fc89c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for your excellent work as usual!
Just a few minor comments for now; I will review several times for a better result.
Many thanks for all the reviews everyone :) I value your comments but I also value your time, so (while I will quickly apply any suggested changes) I should clarify that nothing in this draft PR passes tests yet, and it might take a long time to debug the failures and get this to a mergeable state. Thanks for your patience! |
1541b13
to
9b4ce20
Compare
xcas still works ☑ |
@symphorien Thanks for checking! In a sense |
9b4ce20
to
049865c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heads up: with a single user installation, the store is actually readwrite, and python likes to corrupt the store by compiling pyc files inside it. This can cause strange side effects.
Thank you @symphorien, I did not know this.
Anyway, the failures I am facing occur with or without changes on this branch, so it does not introduce regression on my machine, at least. I have no objections and will approve after rebasing to resolve conflicts.
948b737
to
8504f2f
Compare
@omasanori Rebased. I was going to wait for the cysignals update but I don't think it matters much since I had already imported the relevant patch. So I think this is ready if it passes tests. |
8504f2f
to
961c0ee
Compare
961c0ee
to
3a09354
Compare
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 14 packages built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you all so much for your invaluable help!
@omasanori You're welcome! Thanks for the review. I'll make another PR updating |
it passes tests so let me merge. |
Thank you for your efforts to keep the sage package running and up to date :) |
I will slowly work on this.