Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix usbip listing functionality #116380

Closed
deliciouslytyped opened this issue Mar 15, 2021 · 2 comments · Fixed by #120267
Closed

Fix usbip listing functionality #116380

deliciouslytyped opened this issue Mar 15, 2021 · 2 comments · Fixed by #120267

Comments

@deliciouslytyped
Copy link
Contributor

Add configureFlags = [ "--with-usbids-dir=${hwdata}/share/hwdata/" ]; to
https://github.com/NixOS/nixpkgs/blob/3e6571316c65638e7a4c1aa2f2700e405be82487/pkgs/os-specific/linux/usbip/default.nix based on
https://github.com/NixOS/nixpkgs-channels/blob/4762fba469e2baa82f983b262e2c06ac2fdaae67/pkgs/tools/admin/lxd/default.nix#L32 and
https://github.com/torvalds/linux/blob/fcadab740480e0e0e9fa9bd272acd409884d431a/tools/usb/usbip/configure.ac#L90

before:

$ usbip list -l
usbip: error: failed to open /usr/share/hwdata//usb.ids
 - busid 1-1 (0483:3748)
   unknown vendor : unknown product (0483:3748)

after:

$ usbip --debug list -l
 - busid 1-1 (0483:3748)
   STMicroelectronics : ST-LINK/V2 (0483:3748)
@Luflosi
Copy link
Contributor

Luflosi commented Apr 1, 2021

Is there a reason you didn't make a PR? I tested your suggestion and it seems to work fine.

@deliciouslytyped
Copy link
Contributor Author

deliciouslytyped commented Apr 3, 2021

No, I just didn't feel like doing it at the time, feel free to PR. - also maybe I wasn't sure if I missed something, and just wanted to get it noted down.

Luflosi added a commit to Luflosi/nixpkgs that referenced this issue Apr 22, 2021
SuperSandro2000 pushed a commit that referenced this issue Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants