Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

usbip: fix listing functionality #120267

Merged
merged 1 commit into from Apr 22, 2021

Conversation

Luflosi
Copy link
Contributor

@Luflosi Luflosi commented Apr 22, 2021

Motivation for this change

Closes #116380 for motivation.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 22, 2021

Result of nixpkgs-review pr 120267 at 9cfbb85 run on aarch64-linux 1

2 packages marked as broken and skipped:
  • linuxPackages_4_4.usbip
  • linuxPackages_4_9.usbip
12 packages built successfully:
  • linuxPackages-libre.usbip
  • linuxPackages.usbip (linuxPackages_5_10.usbip ,linuxPackages_hardened.usbip ,linuxPackages_xen_dom0.usbip ,linuxPackages_xen_dom0_hardened.usbip)
  • linuxPackages_4_14.usbip
  • linuxPackages_4_19.usbip
  • linuxPackages_5_11.usbip (linuxPackages_latest.usbip ,linuxPackages_latest_hardened.usbip ,linuxPackages_latest_xen_dom0.usbip ,linuxPackages_latest_xen_dom0_hardened.usbip)
  • linuxPackages_5_4.usbip
  • linuxPackages_hardkernel_4_14.usbip (linuxPackages_hardkernel_latest.usbip)
  • linuxPackages_latest-libre.usbip
  • linuxPackages_lqx.usbip
  • linuxPackages_testing_bcachefs.usbip
  • linuxPackages_xanmod.usbip
  • linuxPackages_zen.usbip

Result of nixpkgs-review pr 120267 at 9cfbb85 run on x86_64-linux 1

2 packages marked as broken and skipped:
  • linuxPackages_4_4.usbip
  • linuxPackages_4_9.usbip
12 packages built successfully:
  • linuxPackages-libre.usbip
  • linuxPackages.usbip (linuxPackages_5_10.usbip ,linuxPackages_hardened.usbip ,linuxPackages_xen_dom0.usbip ,linuxPackages_xen_dom0_hardened.usbip)
  • linuxPackages_4_14.usbip
  • linuxPackages_4_19.usbip
  • linuxPackages_5_11.usbip (linuxPackages_latest.usbip ,linuxPackages_latest_hardened.usbip ,linuxPackages_latest_xen_dom0.usbip ,linuxPackages_latest_xen_dom0_hardened.usbip)
  • linuxPackages_5_4.usbip
  • linuxPackages_hardkernel_4_14.usbip (linuxPackages_hardkernel_latest.usbip)
  • linuxPackages_latest-libre.usbip
  • linuxPackages_lqx.usbip
  • linuxPackages_testing_bcachefs.usbip
  • linuxPackages_xanmod.usbip
  • linuxPackages_zen.usbip
2 suggestions:
  • warning: unclear-gpl

    gpl2 is a deprecated license, please check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

    Near pkgs/os-specific/linux/usbip/default.nix:30:5:

       |
    30 |     license = licenses.gpl2;
       |     ^
    
  • warning: maintainers-missing

    Package does not have a maintainer. Consider adding yourself?

    Near pkgs/os-specific/linux/usbip/default.nix:27:3:

       |
    27 |   meta = with lib; {
       |   ^
    

@SuperSandro2000 SuperSandro2000 changed the title Fix usbip listing functionality usbip: fix listing functionality Apr 22, 2021
@SuperSandro2000 SuperSandro2000 merged commit 9df2614 into NixOS:master Apr 22, 2021
@Luflosi Luflosi deleted the fix-usbip-listing branch April 23, 2021 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix usbip listing functionality
3 participants