-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
juniper: init at 2.3.0 #116576
juniper: init at 2.3.0 #116576
Conversation
Result of 1 package built successfully:2 suggestions:
Result of 1 package built successfully:2 suggestions:
|
maintainers/maintainer-list.nix
Outdated
@@ -10888,4 +10888,10 @@ | |||
github = "zupo"; | |||
githubId = 311580; | |||
}; | |||
wunderbrick = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please put this into a separate commit with the message maintainers: add wunderbrick
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really should add to the template that this needs to be sorted alphabetically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really should add to the template that this needs to be sorted alphabetically.
Would you like me to change the maintainers so mine is in alphabetical order? The last few entries are in no particular order. Please tell me what specifically, if anything, I need to do to get this package merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you like me to change the maintainers so mine is in alphabetical order?
yes please.
The last few entries are in no particular order.
thats by accident. They should be sorted, too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also please drop the commits you added by accident.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash all juniper related commits together.
542a5c6
to
bffb883
Compare
Done, thanks. |
Other than that the package is good to go. Sorry for the delays but to many PRs to look at. |
Motivation for this change
Juniper is a functional reactive programming language for programming Arduino.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)