nixos/flatpak: Remove guiPackages internal option
#123507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: GNOME
It was basically just a `environment.systemPackages` synonym, only GNOME used it, and it was stretching the responsibilities of the flatpak module too far. It also makes it cleaner to avoid installing the program using GNOME module’s `excludePackages` option. Partially reverts: NixOS#101516 Fixes: NixOS#110310
jtojnar
force-pushed
the
no-flatpak-guipkgs
branch
from
64c0c66
to
ed47351
Compare
ofborg
bot
added
10.rebuild-darwin: 0
10.rebuild-linux: 1-10
10.rebuild-linux: 1
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
It was basically just a
environment.systemPackagessynonym, only GNOME used it, and it was stretching the responsibilities of the flatpak module too far.It also makes it cleaner to avoid installing the program using GNOME module’s
excludePackagesoption.Partially reverts: #101516
Fixes: #110310
Things done
GNOME VM still evaluates.