Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harfbuzz's CMake config uses the wrong path #180054

Closed
2xsaiko opened this issue Jul 3, 2022 · 3 comments · Fixed by #207041
Closed

Harfbuzz's CMake config uses the wrong path #180054

2xsaiko opened this issue Jul 3, 2022 · 3 comments · Fixed by #207041
Labels
0.kind: bug
Projects
CMake breakage

Comments

@2xsaiko
Copy link
Contributor

2xsaiko commented Jul 3, 2022

Describe the bug

Trying to use harfbuzz in a CMake project, CMake fails with the following:

CMake Error in CMakeLists.txt:
  Imported target "harfbuzz::harfbuzz" includes non-existent path

    "/nix/store/7ahz2g1i3m2pfk96fjl6j37ldcwlxpbg-harfbuzz-3.3.2-dev//nix/store/7ahz2g1i3m2pfk96fjl6j37ldcwlxpbg-harfbuzz-3.3.2-dev/include/harfbuzz"

  in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:

  * The path was deleted, renamed, or moved to another location.

  * An install or uninstall procedure did not complete successfully.

  * The installation package was faulty and references files it does not
  provide.

That path comes from /nix/store/7ahz2g1i3m2pfk96fjl6j37ldcwlxpbg-harfbuzz-3.3.2-dev/lib/cmake/harfbuzz/harfbuzz-config.cmake, probably on line 25 which says set(_harfbuzz_includedir "${prefix}//nix/store/7ahz2g1i3m2pfk96fjl6j37ldcwlxpbg-harfbuzz-3.3.2-dev/include").

Steps To Reproduce

Steps to reproduce the behavior:

  1. Make a CMake project that tries to link an executable to harfbuzz: 
    find_package(harfbuzz REQUIRED)
add_executable(program main.c)
target_link_libraries(program harfbuzz::harfbuzz)
  2. Try to configure project (cmake .)
  3. See error above

Expected behavior

The project configures successfully.

Notify maintainers

@edolstra

Metadata

Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 5.15.49, NixOS, 22.11 (Raccoon), 22.11.20220627.020c740`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.9.1`
 - nixpkgs: `/etc/nix/inputs/nixpkgs`
@r-burns r-burns mentioned this issue Jul 3, 2022
Open
@r-burns r-burns added this to To do in CMake breakage via automation Jul 3, 2022
@foo-dogsquared foo-dogsquared mentioned this issue Sep 16, 2022
Closed
@2xsaiko

This comment was marked as outdated.

Sign in to view
2xsaiko added a commit to 2xsaiko/harfbuzz that referenced this issue Oct 26, 2022
@2xsaiko
Use path join operator for includedir and libdir in cmake config
228e35f 
When includedir is set to an absolute path, the previous code appends that
absolute path to ${prefix}, which results in a wrong path. The right behavior
would be in this case to drop ${prefix} and just use the absolute path.

This is an issue in nixpkgs, where includedir is set to the final (absolute)
path of the built library in the Nix store.

See NixOS/nixpkgs#180054.
2xsaiko added a commit to 2xsaiko/harfbuzz that referenced this issue Oct 26, 2022
@2xsaiko
Use path join operator for includedir and libdir in cmake config
61d8e9d 
When includedir or libdir are set to an absolute path, the previous code
appends that absolute path to ${prefix}, which results in a wrong path. The
right behavior would be in this case to drop ${prefix} and just use the
absolute path.

This is an issue in nixpkgs, where includedir is set to the final (absolute)
path of the built library in the Nix store.

See NixOS/nixpkgs#180054.
@2xsaiko

This comment was marked as outdated.

Sign in to view
2xsaiko added a commit to 2xsaiko/harfbuzz that referenced this issue Oct 26, 2022
@2xsaiko
Use cmake_path(APPEND) to determine include directory
3a9438a 
The previous code concatenates includedir to _harfbuzz_prefix verbatim, which
results in a wrong resulting include path in case includedir is an absolute
path. The right behavior would be in this case to drop _harfbuzz_prefix and
just use the absolute path which this implements using cmake_path(APPEND).

This is an issue in nixpkgs, where includedir is set to the final (absolute)
path of the built library in the Nix store, which causes CMake projects
depending on harfbuzz to not configure.

See NixOS/nixpkgs#180054.

NB: cmake_path is a function introduced in CMake 3.20, while harfbuzz's
CMakeLists.txt currently specifies 3.12.
2xsaiko added a commit to 2xsaiko/harfbuzz that referenced this issue Oct 26, 2022
@2xsaiko
Pass through absolute paths to cmake-config directly
caf000f 
The previous code concatenates includedir to _harfbuzz_prefix verbatim,
which results in a wrong resulting include path in case includedir is an
absolute path. Instead, we can let meson determine the absolute include and
lib paths in advance and save them in the cmake config.

This is an issue in nixpkgs, where includedir is set to the final (absolute)
path of the built library in the Nix store, which causes CMake projects
depending on harfbuzz to not configure.

See NixOS/nixpkgs#180054.
2xsaiko added a commit to 2xsaiko/harfbuzz that referenced this issue Oct 26, 2022
@2xsaiko
Pass through absolute paths to cmake config directly
26449e4 
The previous code concatenates includedir to _harfbuzz_prefix verbatim,
which results in a wrong resulting include path in case includedir is an
absolute path. Instead, we can let meson determine the absolute include and
lib paths in advance and save them in the cmake config.

This is an issue in nixpkgs, where includedir is set to the final (absolute)
path of the built library in the Nix store, which causes CMake projects
depending on harfbuzz to not configure.

See NixOS/nixpkgs#180054.
2xsaiko added a commit to 2xsaiko/harfbuzz that referenced this issue Oct 26, 2022
@2xsaiko
Pass through absolute paths to cmake config directly
db292f6 
The previous code concatenates includedir to _harfbuzz_prefix verbatim,
which results in a wrong final include path in case includedir is an absolute
path. Instead, we can let meson determine the absolute include and lib paths
in advance and save them in the cmake config.

This is an issue in nixpkgs, where includedir is set to the final (absolute)
path of the built library in the Nix store, which causes CMake projects
depending on harfbuzz to not configure.

See NixOS/nixpkgs#180054.
@2xsaiko 2xsaiko mentioned this issue Oct 26, 2022
Merged
@2xsaiko
Copy link
Contributor Author

2xsaiko commented Dec 20, 2022

Fixed in harfbuzz 6.0.0.

@2xsaiko 2xsaiko mentioned this issue Dec 20, 2022
Merged
13 tasks
@2xsaiko 2xsaiko closed this as completed Jan 4, 2023
CMake breakage automation moved this from To do to Done Jan 4, 2023
@sOfTheApes sOfTheApes mentioned this issue May 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0.kind: bug
Projects
CMake breakage
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

harfbuzz: 5.3.1 -> 6.0.0 2xsaiko/nixpkgs
1 participant
@2xsaiko