Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setuid-wrappers: Update wrapper dir atomically. #18156

Merged
merged 1 commit into from
Aug 31, 2016

Conversation

shlevy
Copy link
Member

@shlevy shlevy commented Aug 31, 2016

Fixes #18124.

@mention-bot
Copy link

@shlevy, thanks for your PR! By analyzing the annotation information on this pull request, we identified @edolstra, @MarcWeber and @peti to be potential reviewers

@shlevy
Copy link
Member Author

shlevy commented Aug 31, 2016

@domenkozar please test

@edolstra edolstra merged commit 448efba into NixOS:master Aug 31, 2016
@edolstra
Copy link
Member

Sorry, didn't see "please test" before hitting merge...

@domenkozar
Copy link
Member

I'm still getting:

dummy> mv: cannot move '/var/setuid-wrappers' to '/var/setuid-wrappers-old': Device or resource busy.

@shlevy
Copy link
Member Author

shlevy commented Aug 31, 2016

Hmm, even with /var/setuid-wrappers-old not existing already?

@shlevy
Copy link
Member Author

shlevy commented Aug 31, 2016

(this may mean that this change has to be activated with nixos-rebuild boot)

@domenkozar
Copy link
Member

Without:

[root@dummy:~]# ls /var/setuid*
setuid-wrappers.2DF8dF0aTv  setuid-wrappers.Pt01NyPpjG  setuid-wrappers.vaeo8U1fcw

@shlevy
Copy link
Member Author

shlevy commented Aug 31, 2016

What the hell, where did those temp names come from?

@domenkozar
Copy link
Member

I activated new configuration three times, this is what was left behind from the error probably.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants