packageOverrides no longer respected by aliases

[edolstra]

For example, in all-packages.nix we have:

dbus_tools = self.dbus.out;
dbus_daemon = self.dbus.daemon;

while in nixos/modules/config/no-x-libs.nix we have:

nixpkgs.config.packageOverrides = pkgs:
  { dbus = pkgs.dbus.override { x11Support = false; }; };

In NixOS 16.09, the override to dbus is no longer propagated to dbus_tools and dbus_daemon. Thus these continue to use libX11. This is a regression from 16.03. (Workaround in ba70ce2.)

Changing self back to pkgs restores the 16.03 behaviour, where overrides did propagate properly.

So should we change self back to pkgs everywhere, or should self be fixed?

[domenkozar]

@nbp

[nbp]

I left a comment on ba70ce2#commitcomment-18902806 .

The easiest solution for the release would be to revert to patches that made these aliases, and add a test to ensure that aliases are expected to alias the overwritten packages, and not the original packages.

To solve this issue, we would either have to move aliases.nix after customOverride, or maybe add a second fix-point to resolve dependencies separately.

[nbp]

This issue is caused by #14398