Using self prevent aliasing overriden packages #18483
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes are reverting #14398 as
self.
refers to theall-packages.nix
set instead of the fix-point including the overriden packages.Apparently, it seems that people used to rely on aliases as dependencies, and expected that overriding a package (which never got specified) should override all aliases of it. (#18316)
This implies that we would have to find another solution for aliases (#10851) , such that we can do a fix-point on aliases before we use the aliases as dependencies. Note, aliases are supposed to be at the same evaluation depth as the package that they alias, otherwise the security model would leak unpatched versions of the packages.
I will note, that this revert include additional removal of
self.
from the derivations/arguments of a few packages which are embedded inall-packages.nix
. Usingself.
is similar to hard-linking and should be avoided as this would cause extra recompilations.@domenkozar @edolstra