Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resend missed Nixpkgs Maintainers organization invites #234293

Open
infinisil opened this issue May 26, 2023 · 30 comments
Open

Resend missed Nixpkgs Maintainers organization invites #234293

infinisil opened this issue May 26, 2023 · 30 comments

Comments

@infinisil
Copy link
Member

infinisil commented May 26, 2023

The automated NixOS organization invites set up after NixOS/rfcs#39 do not allow eligible users to request an invite again in case they missed it. Ideally there should be automation to allow such users to request another invite, but alternatively a manual solution works too.

This is now the case for at least two users, @ners (who asked me personally) and @hellwolf (see here). If you're also affected by this issue, please leave a comment.

Due to the fact that the implementation for these automatic invites appears to be entirely closed-source (Edit: Turns out some version of the source is at least here), there's no way for anybody to fix this themselves. It also appears that @grahamc is the sole person responsible for maintaining this, but I haven't gotten a response for 2 weeks now after asking to re-invite a user manually.

@nixos-discourse
Copy link

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/join-the-package-maintainer-team/3751/66

@alyssais
Copy link
Member

alternatively a manual solution works too.

The manual solution is to ask any other org owner to issue an invite, no?

@hellwolf
Copy link
Contributor

hellwolf commented May 27, 2023

Is it possible to create a github workflow that can be triggered by a smaller group and would have the permission to create invite?

@infinisil
Copy link
Member Author

It looks like GitHub workflows can only be triggered by people with write access to the repo: https://github.com/orgs/community/discussions/49688, so this wouldn't work. The suggested workaround is to use issues instead. I'm guessing we could set it up so that people can get a re-invite by commenting in this thread: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#issue_comment

@06kellyjac
Copy link
Member

I personally had this issue too. Due to github email spam I mostly rely on GH notifications in the web ui but for some reason the invites don't show there.
I also wasn't expecting an immediate invite from being added to maintainer-list.nix and expected it to come later after some consistent contribution

Maybe mentioning "expect a github org invite in your emails" in this header: https://github.com/NixOS/nixpkgs/blob/master/maintainers/maintainer-list.nix#L1-L59
And maybe adding some of this comment to CONTRIBUTING.md would be good?

I'm guessing we could set it up so that people can get a re-invite by commenting in this thread

That sounds good but maybe not just any comment? Maybe a specific format

@infinisil
Copy link
Member Author

That sounds good but maybe not just any comment? Maybe a specific format

For simplicity I'd make it any comment, because the automation would only send an invite if the user is a maintainer but not already in the org. I expect people matching that criteria (but not wanting to be in the org) to not be upset when they get an invite after commenting in a thread called "Resend missed NixOS organization invites" 😄

@hellwolf
Copy link
Contributor

I am hitting this problem again, I'd like to configure the backport label to #237722

Anything short term I could do to unblock myself being able to self service my package maintainer duties?

@06kellyjac
Copy link
Member

To label you need to be in the org, to be in the org you need to post here, not really an alternative other than posting elsewhere too.

If you really want a short term solution an option you have right now is to backport the changes yourself without the label automation but it's a bit more effort.
Go to release branch -> make new branch -> cherry pick commit you want -> push -> create PR against release branch

@hellwolf
Copy link
Contributor

To label you need to be in the org, to be in the org you need to post here, not really an alternative other than posting elsewhere too.

Okay.. can I haz org membership now pls?

@Artturin
Copy link
Member

Im guessing the reason for missing some of them is that the github api is unstable and misses events

@infinisil
Copy link
Member Author

I asked an org admin to add you manually @hellwolf, can you confirm that it worked?

@hellwolf
Copy link
Contributor

@infinisil yes, confirmed! Thank you all!

@rardiol
Copy link
Contributor

rardiol commented Aug 10, 2023

Please invite me

@NotAShelf
Copy link
Member

I hate to piggyback this, but I've previously failed to establish communication with an org owner. I would also like an invitation, if possible.

@nixos-discourse
Copy link

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/where-did-you-get-stuck-in-the-nix-ecosystem-tell-me-your-story/31415/17

@nixos-discourse
Copy link

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/join-the-package-maintainer-team/3751/68

@zimbatm
Copy link
Member

zimbatm commented Aug 11, 2023

Invited rardiol and NotAShelf

@zimbatm zimbatm changed the title Resend missed NixOS organization invites Resend missed Nixpkgs Maintainers organization invites Aug 11, 2023
@NotAShelf
Copy link
Member

Got it, thank you.

@nbraud
Copy link
Contributor

nbraud commented Nov 12, 2023

Could I be re-invited as well? I wasn't expecting to get an automatic invite when added to maintainers-list.nix, so I only noticed it now (half-a-year too late)

nbraud added a commit to nbraud/nixpkgs that referenced this issue Nov 12, 2023
Implements the automation described in NixOS#234293
nbraud added a commit to nbraud/nixpkgs that referenced this issue Nov 12, 2023
Implements the automation described in NixOS#234293
nbraud added a commit to nbraud/nixpkgs that referenced this issue Nov 12, 2023
Implements the automation described in NixOS#234293
nbraud added a commit to nbraud/nixpkgs that referenced this issue Nov 12, 2023
Implements the automation described in NixOS#234293
@frogamic
Copy link
Contributor

Hi there, Could I please be re-invited? I didn't see the original invite until it had expired

@zimbatm
Copy link
Member

zimbatm commented Nov 15, 2023

invited frogamic and nbraud

@FliegendeWurst
Copy link
Member

@tu-maurice doesn't remember getting an invite and would probably appreciate a re-invite :)

@zimbatm
Copy link
Member

zimbatm commented Nov 16, 2023

invited! 🤖

@xrelkd
Copy link
Contributor

xrelkd commented Jan 23, 2024

Please invite me, I maintain several packages as well.

@zimbatm
Copy link
Member

zimbatm commented Feb 1, 2024

done 🤖

@witchof0x20
Copy link
Contributor

witchof0x20 commented Mar 19, 2024

Not sure if this is where to ask, but I also missed an invite!
resolved for me!

@Leixb
Copy link
Member

Leixb commented Mar 19, 2024

Same here

@zimbatm
Copy link
Member

zimbatm commented Mar 19, 2024

function executed 🤖

@tomberek
Copy link
Contributor

invite @YvesStraten

(they reached out and said that their invite failed)

@YvesStraten
Copy link
Contributor

YvesStraten commented Apr 28, 2024

The issue is now resolved for me, I managed to make the link work on another device, no idea why it did not work on the first one. Thank you very much @tomberek for your help 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests