crc: 2.15.0 -> 2.30.0, fix build and update, refactor #277701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use subPackages instead of modRoot - remove unused dependencies - remove unused substitutions in Makefile - set HOME in preCheck, as it is required for tests
- homepage is redirected to some unhelpful RH site, linking the actual docs instead
- update the update script
|
@shikanime sorry, I've missed #228293, otherwise I would have cherry-picked your changes. Also, it seems like you're not part of the nixpkgs-maintainers group even if you are in the maintainers list, so you currently won't be notified and I cannot request your review. Have a look at #234293 if this is unintended. |
|
@katexochen You're right, it's my bad, I completely missed the invitation on a couple of occasions. It isn't really obvious, afaik the missing Microshift was the only problem that prevented the package to run properly, before it was using CDK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
I've stumbled across this package and noticed it was broken (build output was empty) and out of date.
I couldn't actually manage to setup a microshift cluster with this yet, maybe we can add some documentation in
longDescriptionwhat is additionally required to use this (tries to do a hell lot of stuff, libvirt, networkmanager etc). I also have the suspicion that there might be some paths to external tools in the code that need to be patched.Closes #226792
Closes #228293
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 馃憤 reaction to pull requests you find important.