Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskell-packages: ghc-syb-utils tests failing #26689

Closed
ghost opened this issue Jun 18, 2017 · 11 comments
Closed

haskell-packages: ghc-syb-utils tests failing #26689

ghost opened this issue Jun 18, 2017 · 11 comments

Comments

@ghost
Copy link

ghost commented Jun 18, 2017

Issue description

Regression test for this package fails:

running tests
Running 1 test suites...
Test suite regression-tests: RUNNING...

<no location info>: error:
    can't find file: /tmp/nix-build-ghc-syb-utils-0.2.3.1.drv-0/ghc-syb-utils-0.2.3.1/test/test-cases/GithubIssue9.hs
Test suite regression-tests: FAIL
Test suite logged to: dist/test/ghc-syb-utils-0.2.3.1-regression-tests.log
0 of 1 test suites (0 of 1 test cases) passed.
builder for ‘/nix/store/aj4rkxv1iwsna463cwjj8v7pihj5sdyx-ghc-syb-utils-0.2.3.1.drv’ failed with exit code 1
error: build of ‘/nix/store/aj4rkxv1iwsna463cwjj8v7pihj5sdyx-ghc-syb-utils-0.2.3.1.drv’ failed
/run/current-system/sw/bin/nix-shell: failed to build all dependencies

Steps to reproduce

On nixos-unstable:

nix-shell -p haskellPackages.ghc-syb-utils

Technical details

  • System: 17.09pre109180.0d4431cfe9 (Hummingbird)
  • Nix version: nix-env (Nix) 1.11.10
  • Nixpkgs version: 17.09pre109180.0d4431cfe9
  • Sandboxing enabled: No
@mdorman
Copy link
Contributor

mdorman commented Jun 18, 2017

This is a problem with the upstream package (it failed to include that file), and has already been fixed in the 0.2.3.2 release; so once the haskell package set is updated this will go away.

I think @peti is producing an updated package set for 17.03 right now, but perhaps there will be an update to unstable before long. In the meantime you could override doCheck.

@peti
Copy link
Member

peti commented Jun 18, 2017

We haven't updated yet, because LTS Haskell hasn't updated yet. :-/

I committed peti@6f0ebfd to remedy that situation. It will land on master in a day or two.

@pbogdan
Copy link
Member

pbogdan commented Jun 27, 2017

0.2.3.2 also fails to build, the test suite builds but fails with an error. It might be because GHCs >= 8.0 aren't officially supported by the project according to their README. The tests pass when building with ghc7103.
Versions of the package prior to 0.2.3.1 didn't contain a test suite.

@peti
Copy link
Member

peti commented Jun 27, 2017

Is upstream aware of these issues?

@pbogdan
Copy link
Member

pbogdan commented Jun 27, 2017

They are.

@pbogdan
Copy link
Member

pbogdan commented Jun 27, 2017

Investigated a bit more and relayed the details to upstream in DanielG/ghc-syb#20 As noted on that issue I don't know what a proper fix might consist of but hopefully someone more knowledgeable will, and this will get addressed upstream.

@peti
Copy link
Member

peti commented Jun 28, 2017

I'll disable the test suite for GHC 8.x. That will make the build succeed.

peti added a commit to peti/nixpkgs that referenced this issue Jun 29, 2017
The test suite fails when compiling with GHC 8.x. This seems to be a known issue.

Cc: DanielG/ghc-syb#20, NixOS#26689
@sfultong
Copy link
Contributor

How did this get into 17.03? Doesn't travis run before merges?

@peti
Copy link
Member

peti commented Jun 30, 2017

@sfultong, we have build instructions for 11,881 Haskell packages and nobody is getting paid to make sure they all compile ...

@sfultong
Copy link
Contributor

@peti Sorry, I didn't mean to be critical. Would it be feasible to rent a build box for this, or would it simply be impractical? I'd be willing to donate towards this effort.

@peti
Copy link
Member

peti commented Jun 30, 2017

@sfultong, test-building these packages is no issue. In fact, we do compile haskellPackages at http://hydra.nixos.org/jobset/nixpkgs/haskell-updates before merging changes. The issue is not knowing whether a package builds or not, the issue is doing something about those 6,417 packages that we know not to compile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants