Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure: pkgsMusl.jdk8 #281618

Open
superherointj opened this issue Jan 17, 2024 · 10 comments
Open

Build failure: pkgsMusl.jdk8 #281618

superherointj opened this issue Jan 17, 2024 · 10 comments

Comments

@superherointj
Copy link
Contributor

superherointj commented Jan 17, 2024

Steps To Reproduce

  1. nix build .#pkgsMusl.jdk8

Note: openexr error is already fixed in staging. 0b9653816fd556a127b0b9600f7f67cf34de40e5 is cherry-picked.

Build log

/build/source/hotspot/src/share/vm/utilities/globalDefinitions_gcc.hpp:238:39:
 error: ‘isnanf’ was not declared in this scope; did you mean ‘isnan’?
  238 | inline int g_isnan(float  f) { return isnanf(f); }

Log file: pkgsMusl.openjdk.txt

Additional context

No failure in:

  • pkgs.jdk
  • pkgs.jdk8
  • pkgs.jdk11
  • pkgs.jdk17
  • pkgs.jdk20
  • pkgs.jdk21
  • pkgsMusl.jdk
  • pkgsMusl.jdk11
  • pkgsMusl.jdk17
  • pkgsMusl.jdk20
  • pkgsMusl.jdk21
  • pkgsMusl.openjdk8-bootstrap

So it is something specific to pkgsMusl.jdk8.

Notify maintainers

@edwtjo

Reference

superherointj added a commit to superherointj/nixpkgs that referenced this issue Jan 17, 2024
Tracking issue: NixOS#281618

error: ‘isnanf’ was not declared in this scope
@wolfgangwalther
Copy link
Contributor

This could possibly be fixed with https://git.alpinelinux.org/aports/tree/community/openjdk8/icedtea-hotspot-musl.patch

@superherointj
Copy link
Contributor Author

superherointj commented Apr 3, 2024

@wolfgangwalther Thanks for your report.

Do you want to propose a PR fixing it? On yes, forward it to me for review.

(I'm favoring you posting the PR, so you keep the credit for the fix. I have not tested. In case you are not interested in opening the PR. I may do it. But then, I need someone to review it.)

@wolfgangwalther
Copy link
Contributor

(I'm favoring you posting the PR, so you keep the credit for the fix. I have not tested. In case you are not interested in opening the PR. I may do it. But then, I need someone to review it.)

Feel free to open the PR yourself - I am not actually using jdk.

@superherointj
Copy link
Contributor Author

superherointj commented Apr 3, 2024

After patch. Now errors with:

/build/source/hotspot/agent/src/os/linux/proc_service.h:29:10: fatal error: thread_db.h: No such file or directory

But then, there are more patches here:
https://git.alpinelinux.org/aports/tree/community/openjdk8

@wolfgangwalther
Copy link
Contributor

I found #85902, which tried to build jdk8 with pkgsStatic - which is also musl. Might be possible to get some inspiration there.

@AndersonTorres
Copy link
Member

Closing from #281618

@superherointj
Copy link
Contributor Author

superherointj commented Jul 12, 2024

The build failure still exist. Are you sure it makes sense to close this?

@AndersonTorres
Copy link
Member

Hum, the intention is tracking the fixups? OK then!

@superherointj
Copy link
Contributor Author

superherointj commented Jul 12, 2024

I wish I could transfer these issues for some other account, it messes with my GitHub. I have too many.

@AndersonTorres
Copy link
Member

Create a superherointj-nixpkgs org like I did, hihi

shahinism pushed a commit to shahinism/nixpkgs that referenced this issue Jul 15, 2024
Tracking issue: NixOS#281618

error: ‘isnanf’ was not declared in this scope
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants