-
-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
haskell infra: Make sure packages get custom stdenv #28478
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand what problem this change tries to solve.
@peti one of the goals of 74f5fe5 was to allow passing in a custom stdenv, which would be used for I use custom stdenvs to fix the sierra issue without rebuilding GHC to hard-code a different C toolchain. |
One of the goals of 74f5fe5 was to allow passing in a custom stdenv, which would be used for genericBuilder's `mkDerivation` call. That does work, but if packages takes `stdenv` as an parameter for any reason, they'll get the default one instead. This change remedies it.
2c43982
to
19de1f5
Compare
@Ericson2314, I am sorry, but I still don't understand. Where exactly would you like to override |
Are you aware that |
Since callPackage makePackageSet { stdenv = ...; }
What about stand-alone |
Yes, expressions generated by |
@peti What I've done is master...obsidiansystems:more-sierra-hack#diff-209cb9d64e0f91ce90d31759e43bba01R48 That could be rewritten, but I'd think that if |
@peti Also consider
|
@peti Thanks! |
Motivation for this change
The big question is whether stdenv should just be part of
self
, just as it is included in all-packages.N.B. @shlevy this is needed for sierra so I can fish stdenv out (worst case with
callPackages ({ stdenv }: stdenv) {}
) for the-pgml
flag.Things done
No hashes ought to be changed, though I didn't exhaustively check.
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)