Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tor-browser cannot install extension via browser #30443

Closed
unode opened this issue Oct 15, 2017 · 6 comments
Closed

tor-browser cannot install extension via browser #30443

unode opened this issue Oct 15, 2017 · 6 comments
Assignees

Comments

@unode
Copy link
Member

unode commented Oct 15, 2017

Issue description

The latest tor-browser-bundle-bin implements and extensible mechanism that allows adding extensions via nix.
The current implementation replaces the extensions folder in the user's profile directory with a symlink to a /nix/store path.
The extensible mechanism comes at a cost of disallowing installation of extensions through the browser, the most common use-case.

Is there any possibility for a middle ground?
I'd like to still be able to install addons through the browser.

Steps to reproduce

Launch tor-browser
Open add-ons menu
Search and try to install any extension

@joachifm
Copy link
Contributor

Note that only the from-source bundle supports declarative extensions. It also supports installing additional extensions from within the browser.

I think allowing that for the prebuilt bundle should be easy enough, I'll look into it.

@joachifm joachifm self-assigned this Oct 15, 2017
@unode
Copy link
Member Author

unode commented Oct 16, 2017

Just to clarify, I was referring to

ln -snf "$TBB_IN_STORE/TorBrowser/Data/Browser/profile.default/extensions" \

which seems to be absent from the source based build.

@joachifm
Copy link
Contributor

The from-source version relies on a different mechanism for preloading extensions. I expect that using the same mechanism in the binary version would remove the need for the symlink.

@joachifm
Copy link
Contributor

Works for me now

@unode
Copy link
Member Author

unode commented Oct 21, 2017

Works for me too but I had to rm .local/share/tor-browser/TorBrowser/Data/Browser/profile.default/extensions first.

Thanks

@joachifm
Copy link
Contributor

Ah, yeah I forgot about that ... I'll make a note to maybe add some logic to remove the symlink if it exists.

fpletz pushed a commit that referenced this issue Oct 25, 2017
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants