Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google-chrome rendering broken on wayland, version M124 (124.0.6367.60) #306010

Closed
JohnRTitor opened this issue Apr 22, 2024 · 19 comments
Closed
Labels
0.kind: bug 2.status: wait-for-upstream Waiting for upstream fix (or their other action). 9.needs: upstream fix

Comments

@JohnRTitor
Copy link
Contributor

JohnRTitor commented Apr 22, 2024

Describe the bug

Instead of a normal Chrome interface, a blank window appears

Steps To Reproduce

Steps to reproduce the behavior:

  1. Install google-chrome 124.0.6367.60 from unstable
  2. Launch google-chrome-stable
  3. Instead of seeing a normal Chrome window you see a blank window

Expected behavior

A normal Chrome new tab page.

Screenshots

image

Note: the transparency and blur is my Window rule of my tiling window manager Hyprland. Chrome is still unusable even after disabling that.

Additional context

I suspect this is related to recent Mesa update.

This happened after #305145 got merged and mesa 24.0.5 hit unstable yesterday.
I suspect this is either of those problem.

Notify maintainers

@emilylange @networkException

Metadata

Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"

 - system: `"x86_64-linux"`
 - host os: `Linux 6.8.7-cachyos, NixOS, 24.05 (Uakari), 24.05.20240421.6143fc5`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.2`
 - channels(root): `"nixos"`
 - nixpkgs: `/nix/store/cc0ribc27c349w1v2anrby7z8kigy5pq-source`

Add a 👍 reaction to issues you find important.

@networkException
Copy link
Member

@emilylange and I do not maintain google-chrome but chromium.

The bug is known upstream (see https://issues.chromium.org/issues/329678163) and a fix is included in the chromium package (see #304768 (comment)).

Unfortunately users of the google-chrome package will have to wait until Google fixes the issue as patching a proprietary binary is not feasible.

@JohnRTitor
Copy link
Contributor Author

Thanks for the reply. I wasn't sure who to ping since I couldn't find a specific PR of Chrome update, then I realised Chrome inherits, Chromium platform version and Chrome is updated along with Chromium PRs.

And the maintainer of google-chrome apparently is @primeos.

As a temporary workaround, I pinned my google-chrome to 2e359fb, which is the last revision of nixpkgs to have Chrome 123.

Please do update the Chromium package as soon as the fix lands in a release, since google-chrome package inherits its version from Chromium.

I'll let this issue stay open as a tracker, and for those searching for any workaround.

@networkException
Copy link
Member

Please do update the Chromium package as soon as the fix lands in a release, since google-chrome package inherits its version from Chromium.

As I said in my previous comment we already include a fix for this in the chromium package: fb10ea4

@JohnRTitor
Copy link
Contributor Author

JohnRTitor commented Apr 22, 2024

I was talking about incrementing Chromium version.

@emilylange emilylange added 2.status: wait-for-upstream Waiting for upstream fix (or their other action). 9.needs: upstream fix labels Apr 22, 2024
@alyraffauf
Copy link
Contributor

Having the same issue. As a workaround, if you launch Chrome with --ozone-platform=wayland (assuming you are on wayland), it works just fine. Somehow, this is distinct from manually setting the ozone flag to wayland, but it's working in the meantime while we wait for an update

@JohnRTitor
Copy link
Contributor Author

@networkException @emilylange is this fixed on 124.0.6367.78?

@networkException
Copy link
Member

No, Google started including the patch for M126 versions.

@JohnRTitor
Copy link
Contributor Author

Wish someone could request a backport on the chromium.org thread :) The thread is restricted to Google and Chromium devs.

@emilylange
Copy link
Member

#306471 (comment) might be worth a read for those of you that may consider stepping up to maintain google-chrome :)

I would be heavily in favor of making google-chrome independent of chromium.

We (@networkException and I, the current and only chromium maintainers) are already at capacity with chromium (and ungoogled-chromium) maintenance.
We have by no means time to maintain google-chrome as well.

FYI: google-chrome is a binary package, unlike chromium, which is built from source.
Meaning google-chrome is extremely low maintenance, as can be seen from the commit log.

It just needs version bumps.
In theory, splitting the packages might also allow for quicker google-chrome bumps, since chromium may take a bit longer from time to time to fix some issues with our source build before it can be merged.

@emilylange emilylange pinned this issue Apr 24, 2024
@emilylange emilylange changed the title Chrome rendering broke on 124.0.6367.60 google-chrome (Google Chrome) rendering broke on wayland, version M124 (124.0.6367.60) Apr 24, 2024
@emilylange emilylange changed the title google-chrome (Google Chrome) rendering broke on wayland, version M124 (124.0.6367.60) google-chrome rendering broken wayland, version M124 (124.0.6367.60) Apr 24, 2024
@emilylange emilylange changed the title google-chrome rendering broken wayland, version M124 (124.0.6367.60) google-chrome rendering broken on wayland, version M124 (124.0.6367.60) Apr 24, 2024
@nixos-discourse
Copy link

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/google-chrome-not-working-after-recent-nixos-rebuild/43746/8

@nixos-discourse
Copy link

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/chrome-ozone-wayland-glitch/44323/2

@JohnRTitor
Copy link
Contributor Author

The ideal scenario would be google-chrome independent of chromium versions.

It would allow detecting regressions like this, which obviously can't be solved with a patch (this is a prebuilt binary). The release can be pinned to the unaffected version and not be updated until there is a upstream release with the fix.

As a side effect of #305145, the affected google-chrome release have already reached the "stable-23.11" release.

@emilylange IMHO, it should be decoupled before the 24.05 release, else we may see similar situations in the foreseeable future.

Note: this bug has not yet been fixed on stable 124.0.6367.91. The fix appears to have been landed in beta 125.0.6422.14.

@selfisekai
Copy link

it got merged into the m124 branch so it should be part of release tomorrow https://chromium-review.googlesource.com/c/chromium/src/+/5497377

@selfisekai
Copy link

here it is https://chromereleases.googleblog.com/2024/04/stable-channel-update-for-desktop_30.html

@emilylange
Copy link
Member

I find it a bit sad that nobody has come forth so far to maintain google-chrome.

I can help to untie google-chrome from the chromium derivation, to kick-start things, if that's the issue.

Honestly, I might do that either way, considering that if worse comes to worst, @r-ryantm (https://github.com/nix-community/nixpkgs-update) will simply auto-bump google-chrome.

And if not even @r-ryantm ends up bumping google-chrome, I'll have to resort to marking google-chrome as insecure using meta.knownVulnerabilities.

With all of that out of the way:
There is #308358 now, which bumps chromium and by proxy google-chrome to 124.0.6367.118.

After this PR has been merged, it can be tracked using https://nixpk.gs/pr-tracker.html?pr=308358 (or similar).
It will also get backported to 23.11.

@jnsgruk
Copy link
Member

jnsgruk commented May 1, 2024

@emilylange i can try to help with the version bumps etc.

Chrome is a lot bigger and more complicated than anything I've taken on before, but I'm happy to help take care of the "boring stuff" and take advice on the harder bits where needed.

I think splitting it would be a good starting point for sure.

@emilylange
Copy link
Member

Thank you :)

I will start working on separating google-chrome and chromium and will ping you when I am done.

massix added a commit to massix/nixos that referenced this issue May 4, 2024
@massix
Copy link
Contributor

massix commented May 4, 2024

Hello, just FIY, the same issue exists with Microsoft Edge (derivation microsoft-edge-stable) since they're using the same engine as Chrome

@emilylange
Copy link
Member

#308358 and #308401 landed in their according channels by now.

#308383 and #308793 are essentially a no-op, so no need to fair for those two.

Please report future issues with google-chrome to the new google-chrome maintainer @jnsgruk.

Closing.


PS:

Hello, just FIY, the same issue exists with Microsoft Edge (derivation microsoft-edge-stable) since they're using the same engine as Chrome

Please open a new issue and ping the microsoft-edge-stable maintainers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: bug 2.status: wait-for-upstream Waiting for upstream fix (or their other action). 9.needs: upstream fix
Projects
None yet
Development

No branches or pull requests

8 participants