Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qt5 qtModule can subtly break because of src and version being inherited. #46388

Closed
samueldr opened this issue Sep 8, 2018 · 2 comments
Closed
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md

Comments

@samueldr
Copy link
Member

samueldr commented Sep 8, 2018

See #46383 for a subtle breakage.

See #nixos-dev discussion from today

There is probably a need to remove the ability to pass src and version directly to a qtModule using package, since it can accidentally use the src top-level attribute. If a version top-level attribute was to be added, it would remove the happy little accident breaking the builds.

This issue is intended to find an actual solution for this to remove the possibility of such breakage to happen again.

cc @ttuegel @bkchr @LnL7

@LnL7
Copy link
Member

LnL7 commented Sep 8, 2018

Like I mentioned on irc. There are a bunch of other examples in nixpkgs like https://search.nix.gsc.io/?q=version%20%5C%3F&i=nope&files=&repos=, and probably others. The convention of enable flags has the same problem, but I think it's safe to assume those are unique enough to avoid this problem.

@stale
Copy link

stale bot commented Jun 3, 2020

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse.
  3. Ask on the #nixos channel on irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 3, 2020
@samueldr samueldr closed this as not planned Won't fix, can't repro, duplicate, stale Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md
Projects
None yet
Development

No branches or pull requests

2 participants