-
-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libaosd: init at 0.2.7-9-g177589f #48338
Conversation
Success on aarch64-linux (full log) Attempted: libaosd Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: libaosd Partial log (click to expand)
|
Forgive my question, but since this library is unmaintained and already legacy (last commit in 2011), is it really worth adding it to <nixpkgs> now? If you have a private use for it, you could build it locally and push it on Cachix. I'm genuinely curious here, not trying to imply this should be turned down just because it's old |
Hi Renaud, Yes I am using it and since it worked out of the box with minimal effort I found no reason not to include it in nixpkgs. It's present in other distros and some software builds on it. I don't think age should be a major blocker as long as it works. Which is to say that if something does break and is not easily fixed, it would be a candidate for removal. For now it's all in the green. I also saw that there are aosd haskell bindings in nixpkgs but I didn't find a standalone |
sha256 = "1cn7k0n74p6jp25kxwcyblhmbdvgw3mikvj0m2jh4c6xccfrgb9a"; | ||
}; | ||
|
||
buildInputs = [autoconf automake pkgconfig cairo pango libX11 libXcomposite]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
buildInputs = [autoconf automake pkgconfig cairo pango libX11 libXcomposite]; | |
nativeBuildInputs = [ autoconf automake pkgconfig ]; | |
buildInputs = [ cairo pango libX11 libXcomposite ]; | |
enableParallelBuilding = true; |
|
||
buildInputs = [autoconf automake pkgconfig cairo pango libX11 libXcomposite]; | ||
|
||
prePatch = '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prePatch = '' | |
preConfigure = '' |
would be more sensible
Changes implemented |
Success on x86_64-linux (full log) Attempted: libaosd Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: libaosd Partial log (click to expand)
|
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)