wrapGAppsHook without GST (or GRL): makeWrapper doesn't understand the arg GI_TYPELIB_PATH #75443
Comments
|
EDIT: No, the nixos-unstable channel build has that commit, still breaks Hmm, trying to link the |
|
Of course, it's also possible that this is due to my misuse/misunderstanding of wrapGAppsHook, I followed the gnome-music example in the manual. But the following seems to fix it, for nixos-unstable. The question is, is this a necessary and good patch? --- pkgs/build-support/setup-hooks/wrap-gapps-hook.sh 2019-12-10 17:00:45.264978439 +0000
+++ pkgs/build-support/setup-hooks/wrap-gapps-hook.sh.new 2019-12-10 17:00:39.333978461 +0000
@@ -42,7 +42,9 @@
fi
for v in ${wrapPrefixVariables:-} GST_PLUGIN_SYSTEM_PATH_1_0 GI_TYPELIB_PATH GRL_PLUGIN_PATH; do
- gappsWrapperArgs+=(--prefix "$v" : "${!v}")
+ if [ -n "${!v}" ]; then
+ gappsWrapperArgs+=(--prefix "$v" : "${!v}")
+ fi
done
if [[ -z "${dontWrapGApps:-}" ]]; then
I have added this as PR #75450 |
|
We pass and And I cannot reproduce the issue on master, nixos-unstable, nor do I recall ever seeing such issue. We have lot of packages not depending on GStreamer or Grilo, so I would expect the issue to pop up somewhere. |
|
Hmm, I can reproduce it in your repository; even with |
|
Oh, right you are doing |
|
I suggest using |
|
I noticed this recently with python packages, because my example breaks in this fashion. |
It now breaks down as mentioned in NixOS#75443
…ting wrapGAppsHook: don't add empty variables (see also #75443)
|
Thanks both! The suggested preFixup makeWrapperArgs works for me. Closing as there is both a fix to the docs and one for wrap-gapps-hook-shell which has been committed. |
wrapGAppsHook dies without GST
When using wrapGAppsHook, and we don't have any GST plugins, I end up with the (pretty-printed) wrapping
(Extracted with
preFixup = "set -x"andpostFixup = "set +x".)The problem is that the
GST_PLUGIN_SYSTEM_PATH_1_0has no arguments, which should be passed as"", without the quotes the argument becomes the next--prefixwhich messes up the parser for makeWrapper. The following seems to work, though# in a nix-shell, patching the local file, hence ./pye_menu_shell wrapProgram \ ./pye_menu_shell \ --prefix PATH : /nix/store/4c3z5r6yxsf2cxwwyazhdn92xixn4j5b-python3-3.7.5/bin:/nix/store/b3l3niilvqcxcsbxmd6sgqk1dy1rk81c-pye-menu-1.0/bin:/nix/store/y8j1cfj8d9r5rbbxc22w7hnfjw5f4fd3-cairo-1.16.0-dev/bin:/nix/store/6mg7lfbdh9pgx7pbxr3544qqbrigdl1q-freetype-2.10.1-dev/bin:/nix/store/gpszqcy0xi0lavbbjdq82zkkjp3jbp2a-bzip2-1.0.6.0.1-bin/bin:/nix/store/031c5pk5lzabgmpqpyd46hzi625as6bp-libpng-apng-1.6.37-dev/bin:/nix/store/f8kl7kmpv130aw9zm542p74a3hg0yc13-fontconfig-2.12.6-bin/bin:/nix/store/bqp30vkncmm222mjvwggz0s7p318sflj-expat-2.2.7-dev/bin:/nix/store/w57xa8g4s4aviwmqwgra7m5hwj2b005m-glib-2.60.7-dev/bin:/nix/store/v5d4966ahvfir2hwpv003022f3pb7vik-gettext-0.19.8.1/bin:/nix/store/qpvxhl1jr0fxnrx9idnpdagqs00m5m2z-glib-2.60.7/bin \ --set PYTHONNOUSERSITE true \ --set GDK_PIXBUF_MODULE_FILE /nix/store/7ddlakx6xjczqbfs80xjd14f30fzadws-gdk-pixbuf-2.38.1/lib/gdk-pixbuf-2.0/2.10.0/loaders.cache \ --prefix XDG_DATA_DIRS : /nix/store/0snjc1qg89zqn3v35l9d55xrykh9nj5c-gtk+3-3.24.10/share/gsettings-schemas/gtk+3-3.24.10:/nix/store/b41z51vdv11n6df8ki5vj8dynxw98f9l-gsettings-desktop-schemas-3.32.0/share/gsettings-schemas/gsettings-desktop-schemas-3.32.0:/nix/store/0snjc1qg89zqn3v35l9d55xrykh9nj5c-gtk+3-3.24.10/share/gsettings-schemas/gtk+3-3.24.10 \ - --prefix GST_PLUGIN_SYSTEM_PATH_1_0 : \ + --prefix GST_PLUGIN_SYSTEM_PATH_1_0 : "" \ --prefix GI_TYPELIB_PATH : /nix/store/0snjc1qg89zqn3v35l9d55xrykh9nj5c-gtk+3-3.24.10/lib/girepository-1.0:/nix/store/z29l5xaaxh1s0697mcldj71ab0zshry1-librsvg-2.44.15/lib/girepository-1.0:/nix/store/pija1xzm7izxfb5m2hvhvlwp1l38ffxa-gobject-introspection-1.60.2/lib/girepository-1.0 \ - --prefix GRL_PLUGIN_PATH : + --prefix GRL_PLUGIN_PATH : ""To Reproduce
Steps to reproduce the behavior:
git clone https://github.com/KoviRobi/Pye-Menu.gitgit checkout 49b86e1c716eebdbe344721eec99b77538a430dcnix-buildOn the channel
nixos-19.09, withand also with
Expected behavior
The package builds
Screenshots
(Well, kind of a screenshot.)
Additional context
Might be related, #29055
Workaround
Adding gst plugins, even if the program doesn't depend on it, seems to fix it. Or setting
GST_PLUGIN_SYSTEM_PATH_1_0 = ''""''(the string containing an open/close quote pair, which gets expanded to the empty argument). SeeKoviRobi/Pye-Menu@4c95bac
I suspect the proper fix will be in
<nixpkgs/pkgs/build-support/setup-hooks/wrap-gapps-hook.sh>e.g. nixos-19.09 or nixos-unstable, but I don't know enough about it to commit a fix knowing that it won't break other stuffThe text was updated successfully, but these errors were encountered: