Firefox plugins don't work anymore

[petercommand]

Describe the bug
A clear and concise description of what the bug is.

A recent commit to firefox (https://hg.mozilla.org/integration/autoland/rev/9b4e603eb86a ) removed support for loading extensions with the environment variable MOZ_PLUGIN_PATH, and the firefox wrapper in nixpkgs uses this environment variable to load plugins.

To Reproduce
Steps to reproduce the behavior:

1. install firefox
2. set nixpkgs.config.firefox.enableAdobeFlash = true
3. execute firefox

Expected behavior
A clear and concise description of what you expected to happen.

The flash plugin should load

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

Metadata
Please run nix run nixpkgs.nix-info -c nix-info -m and paste the result.

• system: "x86_64-linux"
• host os: Linux 4.19.89, NixOS, 19.09.1625.0dc46b0e1c8 (Loris)
• multi-user?: yes
• sandbox: yes
• version: nix-env (Nix) 2.3
• channels(root): "nixos-19.09.1625.0dc46b0e1c8, nixos-unstable-20.03pre205710.352f030b715"
• nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

Maintainer information:

# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module:

@edolstra
@andir

[taku0]

Related issue of upstream: https://bugzilla.mozilla.org/show_bug.cgi?id=1602308

[peti]

The solution "wait-for-upstream" does not seem to work well. Upstream does not seem to care.

[bjornfor]

There is activity now in the upstream issue, and a patch has been sent for review (direct link: https://phabricator.services.mozilla.com/D68601). I really hope this gets fixed soon.

[bjornfor]

And it landed!

[stale]

Hello, I'm a bot and I thank you in the name of the community for opening this issue.

To help our human contributors focus on the most-relevant reports, I check up on old issues to see if they're still relevant. This issue has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human.

The community would appreciate your effort in checking if the issue is still valid. If it isn't, please close it.

If the issue persists, and you'd like to remove the stale label, you simply need to leave a comment. Your comment can be as simple as "still important to me". If you'd like it to get more attention, you can ask for help by searching for maintainers and people that previously touched related code and @ mention them in a comment. You can use Git blame or GitHub's web interface on the relevant files to find them.

Lastly, you can always ask for help at our Discourse Forum or at #nixos' IRC channel.

[ajs124]

@bjornfor Did it make it into a release? Has this been resolved?

[bjornfor]

@ajs124: Hi, thanks for reminder about this issue. I just checked that setting nixpkgs.config.firefox.enableAdobeFlash = true; enables adobe flash, so this is fixed! (I'm on release-20.03 branch, commit 985047d, which has firefox 80.0.)