-
-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMAKE_INSTALL_DOCDIR set incorrectly without multiple outputs #82304
Comments
Actually, the variable does not seem to be set even with multiple outputs. Which makes sense since there is no configure script. |
Though here
|
Asked on StackOverflow about the best way to continue: |
Perhaps this question is more appropriate for https://discourse.cmake.org/ ? |
This brings cmake inline with the behaviour used for configure scripts, defined in multiple-outputs.sh. It's important because that setup hook will only set shareDocName if multiple outputs are in use (and setOutputFlags hasn't been disabled). So previously, CMAKE_INSTALL_DOCDIR would be set to $out/share/doc for single-output derivations, instead of $out/share/doc/$shareDocName, which would result in collisions. Since this hook now uses the setOutputFlags variable, I had to remove the empty assignment of it added in a714284. Fixes: NixOS#82304
The change was actually reverted, #93166 is a proper fix. |
CMake’s
GNUInstallDirs
module expectsCMAKE_INSTALL_DOCDIR
variable to contain the project name.The issue is that
$shareDocName
used by the setup hooknixpkgs/pkgs/development/tools/build-managers/cmake/setup-hook.sh
Line 80 in 6bba942
is only defined when using multiple outputs:
nixpkgs/pkgs/build-support/setup-hooks/multiple-outputs.sh
Lines 55 to 67 in 6bba942
The text was updated successfully, but these errors were encountered: