Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskell: Should we should run tests for hspec #8664

Closed
Fuuzetsu opened this issue Jul 6, 2015 · 2 comments
Closed

haskell: Should we should run tests for hspec #8664

Fuuzetsu opened this issue Jul 6, 2015 · 2 comments

Comments

@Fuuzetsu
Copy link
Member

Fuuzetsu commented Jul 6, 2015

Currently hspec has doCheck = false presumably due to infinite recursion.

The culprit is stringbuilder test dependency which depends on hspec in its own test-suite.

For hspec therefore, it might be worthwhile enabling tests and simply setting dontCheck on the stringbuilder used for hspec.

In my dev default.nix for hspec, I just have

  testDepends = [
    base directory hspec-core hspec-meta (hlib.dontCheck stringbuilder)
  ];

It does mean that we end up building stringbuilder twice (once normally and once for hspec) but it's a small package.

What do you think @peti ?

peti added a commit to NixOS/cabal2nix that referenced this issue Jul 7, 2015
peti added a commit to peti/nixpkgs that referenced this issue Jul 7, 2015
@peti
Copy link
Member

peti commented Jul 7, 2015

I've made the necessary changes in the haskell-updates branch. Thank you very much for the suggestion! The only risk I see with this kind of trickery is that we don't want stringbuilder ever to become a real dependency of the library, because then it will be propagated to users of the package and we might end up in a situation where builds have two seemingly identical versions of stringbuilder in path without a way to distinguish them.

@Fuuzetsu
Copy link
Member Author

Fuuzetsu commented Jul 7, 2015

Awesome, closing.

@Fuuzetsu Fuuzetsu closed this as completed Jul 7, 2015
peti added a commit to peti/nixpkgs that referenced this issue Jul 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants