libffi: Does not build on OSX 10.7.5

[danieroux]

Started completely clean

sudo rm -rf /nix
rm ~/.nix-channels ~/.nix-profile
rm -rf ~/.nix-defexpr ~/.nixpkgs/
cd / && \
sudo tar xfj ~/Downloads/nix-1.5.3-x86_64-darwin.tar.bz2 && \
sudo chown -R danie /nix && \
nix-finish-install

Then build from #902

$ cd ~/source/nixpkgs && git rev-parse --verify HEAD
f6114a880eb859c8e034e461bfd6b63134dc1e0f
$ nix-env -Ki libffi -f ~/source/nixpkgs 2>&1 | tee /tmp/libffi.log

Fails to build

no such instruction: `vmovdqa %xmm0, (%rsi)'

Log files

• https://gist.github.com/danieroux/6425492
• libffi.log: The tee'd result of nix-env -Ki
• config.log: nix-build-libffi-3.0.13.drv-3/libffi-3.0.13/x86_64-apple-darwin11.4.2/config.log

[vcunat]

Hmm, it does build on hydra, but there seem to be impurities, not just on darwin. At the very least we don't want the configure script to detect -march= according to the build machine (I see corei7-avx and amdfam10 in hydra logs). This can be serious, as many packages depend on libffi through mesa or llvm (I don't know how strongly they depend).

[vcunat]

Would you try if the following patch solves this problem? It should make the resulting binaries portable, at least...

diff --git a/pkgs/development/libraries/libffi/default.nix b/pkgs/development/libraries/libffi/default.nix
index 27c3e9f..3e71663 100644
--- a/pkgs/development/libraries/libffi/default.nix
+++ b/pkgs/development/libraries/libffi/default.nix
@@ -8,6 +8,9 @@ stdenv.mkDerivation (rec {
     sha256 = "077ibkf84bvcd6rw1m6jb107br63i2pp301rkmsbgg6300adxp8x";
   };

+  # no detection of -march= or -mtune=
+  configureFlags = [ "--enable-portable-binary" "--with-gcc-arch=generic" ];
+
   doCheck = true;

   postInstall =

[danieroux]

Yes, that makes it build. Thank you!

[vcunat]

We should thank you. It was lucky that they misdetected architecture on your machine, otherwise we would still be distributing unportable libffi.