Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lazpaint: init at 7.1.3 #92284

Merged
merged 1 commit into from Aug 2, 2020
Merged

lazpaint: init at 7.1.3 #92284

merged 1 commit into from Aug 2, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jul 4, 2020

Motivation for this change

LazPaint is a raster image editor with layers created with Lazarus. It can interoperate with other layered editors via OpenRaster format. It also imports Paint.NET files (with their layer structure). Also, it can import 3d objects in Wavefront (.obj) format.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested executable - drew a cat, and imported a teapot obj.

Looks good to me :-)

Result of nixpkgs-review pr 92284 1

1 package built:
- lazpaint

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/221


buildInputs = [ pango cairo glib atk gtk2 libX11 gdk-pixbuf ];

NIX_LDFLAGS = "--as-needed -rpath ${lib.makeLibraryPath buildInputs}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose this is because our Lazarus build comes without a compiler wrapper?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mic92 Looks like, lazarus needs some care

Copy link
Member

@Mic92 Mic92 Aug 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there is enough interest so. It's quite a niche.

@Mic92
Copy link
Member

Mic92 commented Aug 2, 2020

Result of nixpkgs-review pr 92284 1

1 package built:
- lazpaint

@Mic92 Mic92 merged commit b7d4411 into NixOS:master Aug 2, 2020
@ghost
Copy link
Author

ghost commented Aug 2, 2020

@stigtsp @Mic92 Thank you!

@ghost ghost deleted the lazpaint branch August 2, 2020 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants