qt514.qtbase build broken on darwin

[vcunat]

Example log: https://hydra.nixos.org/build/125099625

ERROR: Cannot compile a minimal program. The toolchain or QMakeSpec is broken.

On master this started to fail in the moment of update: #84232 – but it was merged at once with other staging changes, so I'm not 100% sure that MR was what triggered the failure. This blocks the nixpkgs-unstable channel.

[acowley]

The few lines before that seem informative:

> /private/tmp/nix-build-qtbase-5.14.2.drv-0/qtbase-everywhere-src-5.14.2/mkspecs/features/mac/toolchain.prf:3: Cannot find feature sdk
> Info: creating stash file /private/tmp/nix-build-qtbase-5.14.2.drv-0/qtbase-everywhere-src-5.14.2/config.tests/.qmake.stash
> /private/tmp/nix-build-qtbase-5.14.2.drv-0/qtbase-everywhere-src-5.14.2/mkspecs/features/mac/default_post.prf:5: 'xcodeSDKInfo' is not a recognized replace function.
> Project WARNING: Qt requires at least version 10.14 of the platform SDK, you're building against version . Please upgrade.
+ cd /private/tmp/nix-build-qtbase-5.14.2.drv-0/qtbase-everywhere-src-5.14.2/config.tests/verifyspec && MAKEFLAGS= /nix/store/k3b37yadbn54kbc4yyhf621bxc234zw4-gnumake-4.3/bin/make
> Makefile:69: /private/tmp/nix-build-qtbase-5.14.2.drv-0/qtbase-everywhere-src-5.14.2/mkspecs/features/mac/sdk.mk: No such file or directory
> make: *** No rule to make target '/private/tmp/nix-build-qtbase-5.14.2.drv-0/qtbase-everywhere-src-5.14.2/mkspecs/features/mac/sdk.mk'.  Stop.

The requires at least version 10.14 of the platform SDK, you're building against version part is concerning because our darwin.apple_sdk.sdk.version is 10.12.

[vcunat]

I expect we could keep darwin default at 5.12 for now. We even still have an outdated comment about an earlier case

  # TODO bump to 5.12 on darwin once it's not broken

[sikmir]

The requires at least version 10.14 of the platform SDK, you're building against version part is concerning because our darwin.apple_sdk.sdk.version is 10.12.

#86299 (comment)

[acowley]

@matthewbauer is the only person who's been steering the Apple SDK in nixpkgs ship for a while now, so I think it would be good to let him weigh in on whether or not we hold Qt back on darwin or push to update the SDK. I do not understand how the darwin bootstrapping works well enough to help with an SDK update.

[matthewmazzanti]

I've done some digging here to see if I can help get the channel unblocked. Unfortunately I don't have a Darwin system available, so I cant write/test a patch for this.

First thing to note is that it looks like you can define the platform SDK version you want to build against according to the docs here. This may allow us to set the platform SDK version without breaking a bunch of other builds by trying to upgrade the platform SDK version.

Digging through the logs, right before erroring out it seems that there are two things that blow up:

> /private/tmp/nix-build-qtbase-5.14.2.drv-0/qtbase-everywhere-src-5.14.2/mkspecs/features/mac/default_post.prf:5: 'xcodeSDKInfo' is not a recognized replace function.
> Project WARNING: Qt requires at least version 10.14 of the platform SDK, you're building against version . Please upgrade.

Specifically, the xcodeSDKInfo function is not defined, and from what I can tell is entirely removed as a part of this patch:

nixpkgs/pkgs/development/libraries/qt-5/5.14/qtbase.patch.d/0001-qtbase-mkspecs-mac.patch

Lines 342 to 346 in f9d53e7

	diff --git a/mkspecs/features/mac/sdk.prf b/mkspecs/features/mac/sdk.prf
	deleted file mode 100644
	index 3a9c2778bb..0000000000
	--- a/mkspecs/features/mac/sdk.prf
	+++ /dev/null

Where its defined here. I don't know the history here, so this may be a non-issue, but something to look at.

The other thing of note in the logs is the line version 10.14 of the platform SDK, you're building against version . The empty variable for the current version might indicate that qt is not able to find the platform SDK version. Again, I don't know the full history here so this may be a red herring.

[eqyiel]

I had a go at fixing this, but they actually use SDKs that were added in 10.13.

For example:

rhi/qrhimetal.mm:220:47: error: no type or protocol named 'MTLCaptureScope'
    API_AVAILABLE(macos(10.13), ios(11.0)) id<MTLCaptureScope> captureScope = nil;
                                              ^
rhi/qrhimetal.mm:383:26: error: use of undeclared identifier 'MTLCaptureManager'
        d->captureMgr = [MTLCaptureManager sharedCaptureManager];
                         ^
rhi/qrhimetal.mm:389:25: error: property 'label' not found on object of type 'id'
        d->captureScope.label = label.toNSString();
                        ^
rhi/qrhimetal.mm:1197:25: warning: instance method '-pushDebugGroup:' not found (return type defaults to 'id') [-Wobjc-method-access]
            [cbD->d->cb pushDebugGroup: str];
                        ^~~~~~~~~~~~~~
rhi/qrhimetal.mm:1211:25: warning: instance method '-popDebugGroup' not found (return type defaults to 'id') [-Wobjc-method-access]
            [cbD->d->cb popDebugGroup];
                        ^~~~~~~~~~~~~
rhi/qrhimetal.mm:1264:26: warning: instance method '-beginScope' not found (return type defaults to 'id') [-Wobjc-method-access]
        [d->captureScope beginScope];
                         ^~~~~~~~~~
rhi/qrhimetal.mm:1318:26: warning: instance method '-endScope' not found (return type defaults to 'id') [-Wobjc-method-access]
        [d->captureScope endScope];
                         ^~~~~~~~
rhi/qrhimetal.mm:2941:20: error: use of undeclared identifier 'MTLVertexFormatUCharNormalized'
            return MTLVertexFormatUCharNormalized;
                   ^
rhi/qrhimetal.mm:3643:22: error: property 'displaySyncEnabled' not found on object of type 'CAMetalLayer *'
            d->layer.displaySyncEnabled = NO;
                     ^

http://codeworkshop.net/objc-diff/sdkdiffs/macos/10.13/Metal.html

For the curious eqyiel@50c2b5f

[siraben]

I ran into this issue today when trying to compile pkgs.python3.pkgs.pyqt5

[prusnak]

For reference:

• update macOS SDK issue: Update macOS SDK #101229

[siraben]

@prusnak any updates on this?

[prusnak]

@prusnak any updates on this?

We need to update macOS SDK to 10.14+ first.

[veprbl]

Why is this open? https://hydra.nixos.org/job/nixpkgs/trunk/libsForQt514.qt5.qtbase.x86_64-darwin