Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.shortuuid: disable on Python 2 #100134

merged 1 commit into from Oct 10, 2020


Copy link

@oxzi oxzi commented Oct 10, 2020

Motivation for this change

Compatibility with Python 2 was dropped upstream for release 1.0.0.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits
Compatibility was dropped upstream for release 1.0.0.
@oxzi oxzi requested review from FRidh and jonringer as code owners Oct 10, 2020
@marsam marsam merged commit 9776da9 into NixOS:master Oct 10, 2020
16 checks passed
@oxzi oxzi deleted the shortuuid-py2 branch Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants