Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glibcLocales: fix tarball on Darwin #10069

Closed
wants to merge 1 commit into from

Conversation

Mathnerd314
Copy link
Contributor

https://hydra.nixos.org/build/26376016/nixlog/1/raw

I'm not sure why it worked before.

@vcunat vcunat added the 6.topic: darwin Running or building packages on Darwin label Sep 26, 2015
@vcunat
Copy link
Member

vcunat commented Sep 26, 2015

This might not be a good idea. I suspect darwin people rely on similar attributes to be null, so they can be passed to buildInputs regardless of platform and really get in there only on linux. There were also those *OrEmpty and *OrNull idioms; I'm not sure what's best.

vcunat added a commit that referenced this pull request Sep 26, 2015
@vcunat
Copy link
Member

vcunat commented Sep 26, 2015

For now, I fixed the tarball without changing glibcLocales semantics.

I really do dislike the fact that even if one specifies meta.platforms = platforms.linux, the tarball does try to evaluate the package build phases on darwin. IMO that should be changed.

vcunat added a commit that referenced this pull request Sep 27, 2015
@domenkozar
Copy link
Member

Closing this as it's solved, do open an issue if you want to discuss what's the best method for such evaluation errors.

@domenkozar domenkozar closed this Nov 6, 2015
@Mathnerd314 Mathnerd314 deleted the tarball-fix branch November 6, 2015 18:25
@Mathnerd314
Copy link
Contributor Author

I think #6561 can be that issue, as it is strongly related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants