Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.Theano: add pythonImportsCheck #100867

Merged
merged 1 commit into from Oct 17, 2020

Conversation

@risicle
Copy link
Contributor

@risicle risicle commented Oct 17, 2020

Motivation for this change

This not only gives us a "hint" of test coverage, but also proves the fix from #97597 allows import of theano from within a sandboxed build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
this not only gives us a "hint" of test coverage, but also proves the fix
from #97597 allows import of theano from within a sandboxed build
@risicle risicle force-pushed the risicle:ris-theano-imports-check branch from e9ef4bd to 4a9dba6 Oct 17, 2020
@zowoq
Copy link
Contributor

@zowoq zowoq commented Oct 17, 2020

@ofborg eval

@mweinelt
Copy link
Member

@mweinelt mweinelt commented Oct 17, 2020

Result of nixpkgs-review pr 100867 1

1 package failed to build:
  • python37Packages.pymc3
7 packages built:
  • python27Packages.Lasagne
  • python27Packages.Theano (python27Packages.TheanoWithoutCuda)
  • python27Packages.TheanoWithCuda
  • python37Packages.Theano (python37Packages.TheanoWithoutCuda)
  • python37Packages.TheanoWithCuda
  • python38Packages.Theano (python38Packages.TheanoWithoutCuda)
  • python38Packages.TheanoWithCuda

@mweinelt mweinelt merged commit 23175e4 into NixOS:master Oct 17, 2020
13 of 16 checks passed
13 of 16 checks passed
@github-actions
tests
Details
@github-actions
action
Details
@github-actions
Wait for ofborg This failed status will be cleared when ofborg finishes eval.
Details
@ofborg
grahamcofborg-eval Failed to validate package metadata.
@ofborg
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4a9dba6"; rev="4a9dba6c444b0eb1933b7495dd373173f0034d55"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4a9dba6"; rev="4a9dba6c444b0eb1933b7495dd373173f0034d55"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4a9dba6"; rev="4a9dba6c444b0eb1933b7495dd373173f0034d55"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4a9dba6"; rev="4a9dba6c444b0eb1933b7495dd373173f0034d55"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4a9dba6"; rev="4a9dba6c444b0eb1933b7495dd373173f0034d55"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4a9dba6"; rev="4a9dba6c444b0eb1933b7495dd373173f0034d55"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4a9dba6"; rev="4a9dba6c444b0eb1933b7495dd373173f0034d55"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants