Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

steam: added libcxxabi workaround #10093

Merged
merged 1 commit into from
Sep 27, 2015
Merged

steam: added libcxxabi workaround #10093

merged 1 commit into from
Sep 27, 2015

Conversation

yochai
Copy link
Contributor

@yochai yochai commented Sep 27, 2015

Changes tested on unstable 68bd8e4M and they work to allow launching Sid Meier's Civilization V.

jagajaga added a commit that referenced this pull request Sep 27, 2015
steam: added libcxxabi workaround
@jagajaga jagajaga merged commit 8d1dd26 into NixOS:master Sep 27, 2015
@chris-martin
Copy link
Contributor

Have you managed to get Civ 5 fully working? I just pulled this commit into my build based on nixos-15.09, and it fixes the immediate crash - But now it just spends some time on the first loading screen and then crashes.

@chris-martin
Copy link
Contributor

Nevermind, not sure what caused that crash but it's working now. Thanks for providing this fix!

@jagajaga
Copy link
Member

jagajaga commented Oct 4, 2015

Sorry, I have to revert this commit, because with it I can't play some games (dota 2, team fortress 2). I have the same issue as @chris-martin (game starts and crashes).

@jagajaga
Copy link
Member

jagajaga commented Oct 4, 2015

e822dfd

@yochai
Copy link
Contributor Author

yochai commented Oct 4, 2015

@jagajaga @chris-martin mentioned that it's working for him. Can you please send the crash logs ?

@jagajaga
Copy link
Member

jagajaga commented Oct 4, 2015

@yochai
Copy link
Contributor Author

yochai commented Oct 4, 2015

@jagajaga removing the libstdc++.so export (on master's version) from the chrootenv allows to play both dota 2 and civ 5, can that export be made optional ?

@jagajaga
Copy link
Member

jagajaga commented Oct 4, 2015

@yochai removing libc++abi.so helped me, not libstdc++.so.

@jagajaga
Copy link
Member

jagajaga commented Oct 4, 2015

cc @abbradar

@yochai
Copy link
Contributor Author

yochai commented Oct 5, 2015

@jagajaga we had a misunderstanding, locally I can play both dota 2 and civ 5 when libstdc++.so and libc++abi.so are not being exported. libstdc++.so is being exported as a workaround for an issue that doesn't effect everyone, but this export breaks Civ 5.
If the libc++abi.so export is removed and the libstdc++.so export is made optional, those who are not effected by this bug will be able to play Civ 5.

@jagajaga
Copy link
Member

jagajaga commented Oct 5, 2015

You mean that we need to unimport libstdc++.so? Well, let's wait for @abbradar's comments.

@jagajaga
Copy link
Member

jagajaga commented Oct 5, 2015

@abbradar

@abbradar
Copy link
Member

abbradar commented Oct 5, 2015

Well, as far as I remember libstdc++ is needed for FOSS drivers only -- optional support would indeed be better if it can give breakage However I think it would be nicer to move this work on top of #8299 -- it can potentially fix lots of other things (and without LD_PRELOADs!). Would you mind?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants