Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run elm update script #101085

Merged
merged 1 commit into from Oct 20, 2020
Merged

Run elm update script #101085

merged 1 commit into from Oct 20, 2020

Conversation

@jaredramirez
Copy link
Contributor

@jaredramirez jaredramirez commented Oct 19, 2020

Ran the elm update script

elm-language-server 1.13.1
create-elm-app 5.9.0

Very similar to #99671

Motivation for this change

Upgrade elm-language-server, current nixpkg version elm-language-server had a bug that caused it to fail in vim

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@turboMaCk - You were @'d in the last elm pr, so I'm mentioning you here too!

Copy link
Contributor

@jonringer jonringer left a comment

commit should probably be:

elmPackages: update

please amend commit

@jaredramirez jaredramirez force-pushed the jaredramirez:master branch from 4906ee0 to 7c4f9e4 Oct 19, 2020
@jaredramirez
Copy link
Contributor Author

@jaredramirez jaredramirez commented Oct 19, 2020

Renamed commit

Copy link
Contributor

@jonringer jonringer left a comment

LGTM

https://github.com/NixOS/nixpkgs/pull/101085
10 packages built:
elmPackages.create-elm-app elmPackages.elm-analyse elmPackages.elm-coverage elmPackages.elm-doc-preview elmPackages.elm-language-server elmPackages.elm-live elmPackages.elm-optimize-level-2 elmPackages.elm-test elmPackages.elm-upgrade elmPackages.elm-verify-examples
@jonringer jonringer merged commit 8545f5d into NixOS:master Oct 20, 2020
17 checks passed
17 checks passed
@github-actions
tests
Details
@github-actions
action
Details
@ofborg
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions
Wait for ofborg
Details
@ofborg
grahamcofborg-eval ^.^!
Details
@ofborg
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7c4f9e4"; rev="7c4f9e4c79fefbc05a3e9429c6b52c34a6b77dc4"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7c4f9e4"; rev="7c4f9e4c79fefbc05a3e9429c6b52c34a6b77dc4"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7c4f9e4"; rev="7c4f9e4c79fefbc05a3e9429c6b52c34a6b77dc4"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7c4f9e4"; rev="7c4f9e4c79fefbc05a3e9429c6b52c34a6b77dc4"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7c4f9e4"; rev="7c4f9e4c79fefbc05a3e9429c6b52c34a6b77dc4"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7c4f9e4"; rev="7c4f9e4c79fefbc05a3e9429c6b52c34a6b77dc4"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7c4f9e4"; rev="7c4f9e4c79fefbc05a3e9429c6b52c34a6b77dc4"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@turboMaCk
Copy link
Member

@turboMaCk turboMaCk commented Oct 20, 2020

thanks @jaredramirez

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants