Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixosTests.certmgr: fix systemd test #101260

Merged
merged 1 commit into from Oct 24, 2020
Merged

Conversation

@B4dM4n
Copy link
Contributor

@B4dM4n B4dM4n commented Oct 21, 2020

Motivation for this change

The nixosTests.certmgr.systemd test currently fails on master and release-20.09.

The nginx service fails to start, because it can't read the generated certificate file. This happens because PrivateTmp is set for the service, which makes the system wide /tmp inaccessible.

master build: https://hydra.nixos.org/build/128741218
release-20.09 build: https://hydra.nixos.org/build/128677093

ZHF: #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Nginx fails to start, because it can't read the certificate file. This
happens because PrivateTmp is set for the service, which makes the
system wide /tmp inaccessible.
@jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 24, 2020

@GrahamcOfBorg test certmgr

@jonringer jonringer merged commit e83bd25 into NixOS:master Oct 24, 2020
18 checks passed
@B4dM4n B4dM4n deleted the certmgr-test-fix branch Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants