Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/throttled: disable kernel msr warning #102106

Merged
merged 1 commit into from Dec 29, 2020

Conversation

@tadfisher
Copy link
Contributor

@tadfisher tadfisher commented Oct 29, 2020

Motivation for this change

Kernel 5.9 has begun printing warnings whenever userspace writes to CPU MSR registers, which throttled does to control CPU voltage. See erpalma/throttled#215

The kernel devs are working on a solution for this issue, which may involve a new API for controlling CPU voltage. See https://lore.kernel.org/lkml/20200907094843.1949-1-Jason@zx2c4.com/T/#u

In the meantime, to avoid spamming the kernel log buffer, enable msr.allow_writes for kernels 5.9 and newer.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@bkchr
bkchr approved these changes Nov 11, 2020
Copy link
Contributor

@bkchr bkchr left a comment

Works for me 👍

@Patryk27
Copy link
Member

@Patryk27 Patryk27 commented Nov 17, 2020

Works for me too 👍

@flokli
Copy link
Contributor

@flokli flokli commented Dec 29, 2020

Too bad the LKML discussion has gotten somewhat silent. Setting this in the throttled module is probably fine.

@flokli flokli merged commit 316862f into NixOS:master Dec 29, 2020
16 checks passed
16 checks passed
@github-actions
tests
Details
@github-actions
action
Details
@ofborg
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions
Wait for ofborg
Details
@ofborg
grahamcofborg-eval ^.^!
Details
@ofborg
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e07f4d6"; rev="e07f4d6795413d98a2b871d5a8e03d6a9bd16e0f"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e07f4d6"; rev="e07f4d6795413d98a2b871d5a8e03d6a9bd16e0f"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e07f4d6"; rev="e07f4d6795413d98a2b871d5a8e03d6a9bd16e0f"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e07f4d6"; rev="e07f4d6795413d98a2b871d5a8e03d6a9bd16e0f"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e07f4d6"; rev="e07f4d6795413d98a2b871d5a8e03d6a9bd16e0f"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e07f4d6"; rev="e07f4d6795413d98a2b871d5a8e03d6a9bd16e0f"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e07f4d6"; rev="e07f4d6795413d98a2b871d5a8e03d6a9bd16e0f"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants