Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skype_call_recorder: drop #102164

Merged
merged 1 commit into from Oct 31, 2020
Merged

Conversation

@ajs124
Copy link
Member

@ajs124 ajs124 commented Oct 30, 2020

Motivation for this change

hasn't worked since 2017: https://atdot.ch/scr/2017/06/important-information-regarding-skype-version-5/
the version packaged here is also from 2008, as far as I can tell
the last upstream release was 2016

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 30, 2020

Can you add an entry to pkgs/top-level/aliases.nix that throws an error that the package was removed?

hasn't worked since 2017: https://atdot.ch/scr/2017/06/important-information-regarding-skype-version-5/
the version packaged here is also from 2008, as far as I can tell
the last upstream release was 2016
@ajs124 ajs124 force-pushed the drop/skype-call-recorder branch from 7efc29f to a5bce15 Oct 30, 2020
@ajs124 ajs124 merged commit edce0de into NixOS:master Oct 31, 2020
16 checks passed
16 checks passed
@github-actions[bot]
tests
Details
@github-actions[bot]
action
Details
@ofborg[bot]
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions[bot]
Wait for ofborg
Details
@ofborg[bot]
grahamcofborg-eval ^.^!
Details
@ofborg[bot]
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg[bot]
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a5bce15"; rev="a5bce15b5dc04e5e32abde659db79e4e1859d655"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg[bot]
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a5bce15"; rev="a5bce15b5dc04e5e32abde659db79e4e1859d655"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a5bce15"; rev="a5bce15b5dc04e5e32abde659db79e4e1859d655"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a5bce15"; rev="a5bce15b5dc04e5e32abde659db79e4e1859d655"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a5bce15"; rev="a5bce15b5dc04e5e32abde659db79e4e1859d655"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a5bce15"; rev="a5bce15b5dc04e5e32abde659db79e4e1859d655"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a5bce15"; rev="a5bce15b5dc04e5e32abde659db79e4e1859d655"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg[bot]
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@ajs124 ajs124 deleted the drop/skype-call-recorder branch Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants