-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ROCm to 3.9.0 #102602
Update ROCm to 3.9.0 #102602
Conversation
Also fix lld path in the installed CMake files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! nixpkgs-review runs though fine and the OpenCL samples started working for me again
I haven't yet had a chance to test, but I'm curious if we will feel some of the issues with the 3.9 release, such as these changes to rocm-smi. |
Thanks for pointing to this issue. Let me know if it works. If not, I will remove the update of rocm-smi from this PR. |
Good to go! The patch applied cleanly to the overlay, but |
Motivation for this change
Updates the ROCm OpenCL stack
cc: @acowley @Flakebi
My RX580 is still on the shelf, so would appreciate a test on real hardware.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)