Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tinyobjloader: init at 1.0.6 #105543

Merged

Conversation

IvarWithoutBones
Copy link
Member

Motivation for this change

I've also added the python bindings, which were a bit of a pain to package.

They require some headers from the tinyobj source, but simply adding this as a buildInput won't work.

Not sure if my solution is proper, very much open for feedback.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used rg 'inherit \(' pkgs/development/python-modules/ and there are other packages which does similar things. I think this is fine.

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Dec 1, 2020

Result of nixpkgs-review pr 105543 run on x86_64-linux 1

3 packages marked as broken and skipped:
  • python37Packages.tinyobjloader-py
  • python38Packages.tinyobjloader-py
  • python39Packages.tinyobjloader-py
1 package built:
  • tinyobjloader
running egg_info
writing tinyobjloader.egg-info/PKG-INFO
writing dependency_links to tinyobjloader.egg-info/dependency_links.txt
writing top-level names to tinyobjloader.egg-info/top_level.txt
reading manifest file 'tinyobjloader.egg-info/SOURCES.txt'
writing manifest file 'tinyobjloader.egg-info/SOURCES.txt'
running build_ext
copying build/lib.linux-x86_64-3.8/tinyobjloader.cpython-38-x86_64-linux-gnu.so ->

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105543 run on x86_64-darwin 1

3 packages marked as broken and skipped:
  • python37Packages.tinyobjloader-py
  • python38Packages.tinyobjloader-py
  • python39Packages.tinyobjloader-py

@IvarWithoutBones
Copy link
Member Author

IvarWithoutBones commented Dec 1, 2020

With all the above suggestions applied, everything seems to work :)

Result of nixpkgs-review pr 105543 run on x86_64-linux 1

4 packages built:
  • python37Packages.tinyobjloader-py
  • python38Packages.tinyobjloader-py
  • python39Packages.tinyobjloader-py
  • tinyobjloader

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105543 run on x86_64-linux 1

4 packages built:
  • python37Packages.tinyobjloader-py
  • python38Packages.tinyobjloader-py
  • python39Packages.tinyobjloader-py
  • tinyobjloader

@SuperSandro2000 SuperSandro2000 merged commit 385ec3e into NixOS:master Dec 1, 2020
@IvarWithoutBones IvarWithoutBones deleted the tinyobjloader-init-1.0.6 branch December 1, 2020 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants