New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tinyobjloader: init at 1.0.6 #105543
tinyobjloader: init at 1.0.6 #105543
Conversation
87d5a44
to
358187d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used rg 'inherit \(' pkgs/development/python-modules/
and there are other packages which does similar things. I think this is fine.
Result of 3 packages marked as broken and skipped:
1 package built:
|
Result of 3 packages marked as broken and skipped:
|
358187d
to
6f65e5c
Compare
With all the above suggestions applied, everything seems to work :) Result of 4 packages built:
|
Result of 4 packages built:
|
Motivation for this change
I've also added the python bindings, which were a bit of a pain to package.
They require some headers from the tinyobj source, but simply adding this as a
buildInput
won't work.Not sure if my solution is proper, very much open for feedback.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)