-
-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qemu: 5.1.0 -> 5.2.0 #106988
qemu: 5.1.0 -> 5.2.0 #106988
Conversation
6282741
to
43c875f
Compare
Would it make sense to add meson as a dep (and EDIT: tried building this but it wouldn't build without a new |
Can confirm the libpixman issue. This is causing build errors for some downstream packages from
EDIT: actually, it's probably not related. Think I need to add |
Yeah I'm not sure what's going on because |
@arcnmx I can't say anything about whether After adding
It seems that this dynamic library isn't being patched like the rest. I checked the derivation's |
43c875f
to
8f96343
Compare
8f96343
to
cd77ce2
Compare
Same for Did you build this with an enabled sandbox? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fails to build currently.
@drewrisinger I also can't build this on NixOS with the same error that @flokli reported. |
@drewrisinger It might also be a good idea to split the version update from switching the build system, if this is possible. |
@drewrisinger please fix the merge conflict. |
cd77ce2
to
30cc3f8
Compare
Not easily possible without patching. I get the following error when I try building without Currently in process of doing a full |
dd5cf40
to
838d64c
Compare
Updates to latest version of QEMU. The build system has changed to ninja. There are several configuration flags that aren't enabled. I will defer to maintainers on those. Adds autoPatchelfHook for patching output dynamically linked binaries. qemu: use Nix's meson vs bundled qemu: remove custom directory locations It appears that these directories are no longer automatically prefixed with $out/, so they are now trying to write to the system /etc/, /var/ directories, which is not permitted in sandbox. The default directories seem to work OK, so using those.
838d64c
to
9e403b1
Compare
@drewrisinger Awesome. I gave this a shot and it builds and works. :) The changes look great as well. |
This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 2 packages marked as broken and skipped:
2 packages blacklisted:
2 packages failed to build and already failed to build on hydra master:
12 packages failed to build and are new build failures:
33 packages built:
The following issues got detected with the above build packages. virtualboxHeadless: Please consider this feature to be alpha. A substituteInPlace with an unused --replace got detected:
Please check the offending substituteInPlace for typos or changes in source. |
This change doesn't build for me on a darwin system using clang due to the autoPatchElf script not having $READELF defined. I'm not sure the proper fix, but I am trying to build with exporting READELF in preConfigure. @drewrisinger |
Found error in guest-agent:
|
Simple fix:
Create PR or this variant is not suitable? |
qemu-guest-agent fixed in #110927 |
Using https://github.com/Mic92/nixos-shell, when I add the line
I get
|
I dropped autoPatchelfHook because it got confused with the debug objects, and I can't reproduce the pixman linker errors that caused it to be introduced in NixOS#106988 ("qemu: 5.1.0 -> 5.2.0").
Motivation for this change
Noticed a recent bump to QEMU version.
https://wiki.qemu.org/ChangeLog/5.2
NOTE: build system changed: https://wiki.qemu.org/ChangeLog/5.2#Build_Information
I wasn't sure if some of these options were supposed to be enabled by default, so I included the list here.
Options we have/haven't enabled (default build)
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)