Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] graphicsmagick: 1.3.35 -> 1.3.36 #111587

Merged
merged 1 commit into from
Feb 2, 2021
Merged

[20.09] graphicsmagick: 1.3.35 -> 1.3.36 #111587

merged 1 commit into from
Feb 2, 2021

Conversation

LeSuisse
Copy link
Contributor

@LeSuisse LeSuisse commented Feb 1, 2021

Motivation for this change

Fix for CVE-2020-12672.

(cherry picked from commit 58ba659)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@LeSuisse
graphicsmagick: 1.3.35 -> 1.3.36
e75632f 
Fix for CVE-2020-12672.

(cherry picked from commit 58ba659)
@tomberek
Copy link
Contributor

tomberek commented Feb 1, 2021

Result of nixpkgs-review pr 111587 run on x86_64-linux 1

6 packages marked as broken and skipped:
  • fileshelter
  • octave-jit
  • photivo
  • wt
  • wt3
  • wt4
32 packages built:
  • darktable
  • dosbox
  • fastlane
  • gama
  • gimp-with-plugins
  • gimpPlugins.gmic
  • gitlab
  • gitlab-ee
  • glsurf
  • gmic
  • gmic-qt
  • gmic-qt-krita
  • graphicsmagick
  • graphicsmagick-imagemagick-compat
  • graphicsmagick_q16
  • herwig
  • hydron
  • keen4
  • minc_widgets
  • octave
  • octaveFull
  • pdf2djvu
  • photoqt
  • python37Packages.rivet
  • rivet (python38Packages.rivet)
  • redmine
  • rubyPackages.mini_magick (rubyPackages_2_6.mini_magick)
  • rubyPackages_2_5.mini_magick
  • rubyPackages_2_7.mini_magick
  • sherpa
  • thepeg
  • vdrPlugins.text2skin

tomberek
tomberek approved these changes Feb 1, 2021
View reviewed changes
Copy link
Contributor

@tomberek tomberek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure if the broken packages are new or not, but spot-checking the functionality in gm itself seems fine.

@marsam marsam merged commit 8cef653 into NixOS:release-20.09 Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomberek tomberek tomberek approved these changes

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LeSuisse @tomberek @marsam