New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Submit/cups update #1120
Submit/cups update #1120
Conversation
Setting LogLevel to debug or debug2 and commenting syslog lines might be useful. You'll get logs at /var/log/cups/* |
-1 I don't want the experimental non-standard "versionedDerivation" all over the place in those vital expressions. |
I don't like you calling it "experimental'. Creating a third "open issue" wiki page discussing all views would be the way to go. I agree that there are different views on this topic. Good old news: Its trivial to rewrite. If you look closely at the commit there are still many things to be fixed. Eg printing .ps files does not work. There is an open question whether we want to support both versions till we know that the knew one pleases everyone and all use cases etc. The perfect solution would introduce /etc/cups and /etc/cups-new so that you can switch easily. So there is much more to discuss than just "versionedDerivation" which really is handy if you want try many versions fast. So consider assisting with those additional topics, too. |
Could you summarize the changes in pull request? That way pull request looks more attractive to be reviewed :) |
I assume github does not send updates, so I'm adding a comment telling that I've changed the description to contain a summary. The important description can be found in the cups-1.6-1.7 commit. |
Thanks! |
versionedDerivation: is there any reason in this case to actually have other than the latest version in nixpkgs? Having just one would simplify the expression and maintenance. (I originally thought this has been merged already, but I don't see it in master yet.) |
@vcunat: Please not that its getting harder to maintain because the modules now build custom cups related packages using deep override. So in the end versionedDerivation does not make a big difference IMHO. As I said previously this is "work in progress" and we can change details. Its more important that we fix the remaining ps printing issue, printing test pages and get more testers. |
Marc, you always say that you're willing to change details about the As far as I am concerned, I have zero incentive to review your work, |
I consider fixing the remaining issues more important:
Compared to this the versionedDerivation usage is peanuts. Arguments like "you always" are bad style and unfair. Give references. So I don't think this is most important issue about nixos/nixpkgs/... |
opt-out cups update: The new cupsd-1.6.nix file is default, you can still uncomment the old one. Both module have a new option "cupsPackages" which is the way to specifiy which cups/ghostscript versions to use. 1.6.4+ comes with some changes: - default filter chain is PDF, gs is only used for gs printers - some stuff has been moved into cupsFilters and is maintained by openprinting now - cups has 2 configuration files now - some more less important changes such as compressing print files sent over the network and whatnot (I didn't test them) Issues: - printing test pages does not work yet fixes: - printing on canon-bjc like printers using gutentprint drivers. 1.5.4 only prints 30% of page for whatever reason. new packages: ijs, qpdf ghostscript: get back the update which got reverted while keeping the old version This includes b96fc98 pull/1115
I think the current policy on |
This pull request consists of two patches: