Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prometheus: Support metric_relabel_configs in scrapeConfigs #112207

Closed
wants to merge 1 commit into from
Closed

prometheus: Support metric_relabel_configs in scrapeConfigs #112207

wants to merge 1 commit into from

Conversation

zhaofengli
Copy link
Member

Motivation for this change

This commit makes it possible to configure metric_relabel_config in scrapeConfigs. Upstream documentations are available here.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zhaofengli zhaofengli changed the title modules: Support metric_relabel_configs in scrapeConfigs prometheus: Support metric_relabel_configs in scrapeConfigs Feb 7, 2021
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/468

PanAeon
PanAeon approved these changes May 10, 2021
View reviewed changes
Copy link
Contributor

@PanAeon PanAeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@yrd yrd mentioned this pull request Nov 5, 2021
Merged
12 tasks
@yrd
Copy link
Member

yrd commented Nov 8, 2021

@zhaofengli Could you please check if this can be closed in favor of #142654?

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 19, 2022
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 26, 2022
@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 7, 2023
@bjornfor
Copy link
Contributor

bjornfor commented Nov 8, 2023

This option exist since NixOS 21.05. Here in master branch:

nixpkgs/nixos/modules/services/monitoring/prometheus/default.nix

Line 449 in ec750fd

metric_relabel_configs = mkOpt (types.listOf promTypes.relabel_config) ''

Closing.

@bjornfor bjornfor closed this Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PanAeon PanAeon PanAeon approved these changes

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zhaofengli @nixos-discourse @yrd @bjornfor @PanAeon @bobby285271