Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode-extensions: Update/add extensions #112230

Merged
merged 15 commits into from
Mar 26, 2021

Conversation

kubukoz
Copy link
Member

@kubukoz kubukoz commented Feb 6, 2021

Updates the following extensions:

  • ms-azuretools.vscode-docker: 0.8.1 -> 1.9.1
  • scala-lang.scala: 0.4.5 -> 0.5.1
  • scalameta.metals: 1.9.10 -> 1.9.13

Adds the following extensions:

  • alygin.vscode-tlaplus: 1.5.3
  • baccata.scaladex-search: 0.0.1
  • codezombiech.gitignore: 0.6.0
  • edonet.vscode-command-runner: 0.0.116
  • github.vscode-pull-request-github: 0.22.0
  • mishkinf.goto-next-previous-member: 0.0.5
  • shyykoserhiy.vscode-spotify: 3.2.1
  • slevesque.vscode-multiclip: 0.1.5
  • timonwong.shellcheck: 0.12.3
  • xyz.local-history: 1.8.1
  • yzhang.markdown-all-in-one: 3.4.0
  • zhuangtongfa.material-theme: 3.9.12

Remaining changes are a result of automatic reformatting via the nixfmt
extension.

Motivation for this change

Wanting newer / more extensions without maintaining a list of all the versions/shas myself ;)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/) - doesn't apply
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To comply with the contributing guide each package update and addition needs to be its own commit. The formatting changes should also get their own commit.

pkgs/misc/vscode-extensions/default.nix Outdated Show resolved Hide resolved
@kubukoz
Copy link
Member Author

kubukoz commented Feb 7, 2021

To comply with the contributing guide each package update and addition needs to be its own commit. The formatting changes should also get their own commit.

Understandable, I'll split it tomorrow :) and I guess I'll get rid of the formatting changes too.

@kubukoz
Copy link
Member Author

kubukoz commented Mar 12, 2021

Took some time but I think it matches the requirements now :) @SuperSandro2000

@kubukoz
Copy link
Member Author

kubukoz commented Mar 25, 2021

Can we get this merged? I have to fix conflicts every now and then and it looks like all the comments have been addressed.

@SuperSandro2000 SuperSandro2000 merged commit df1b047 into NixOS:master Mar 26, 2021
@kubukoz kubukoz deleted the vscode-extension-updates branch March 26, 2021 18:35
@kubukoz
Copy link
Member Author

kubukoz commented Mar 26, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants